Hi.

I've been using this module for a few hours and I noticed that in the composer.json file you have "hybridauth" as dependency.

But that library is not used in the module.

In my next comment, a patch removing this dependency.

Thanks!

CommentFileSizeAuthor
#2 2858267-twitter-hybridauth-2.patch397 bytesgnuget

Comments

gnuget created an issue. See original summary.

gnuget’s picture

gnuget
Primary language Spanish
commented
Status: Active » Needs review
StatusFileSize
new 2858267-twitter-hybridauth-2.patch397 bytes

Patch attached.

Thanks.

  • gvso committed 62f6841 on 8.x-1.x 
    Issue #2858267 by gnuget: Unused hybridauth
gvso’s picture

gvso
Primary language Spanish
commented
Status: Needs review » Fixed

HybridAuth was added as a dependency since we first thought of using it as the library for the implementers. We end up allowing developers to use whatever library they want to use (including HybridAuth). Although we are trying to implement a library (theleague, hybridauth, etc) as a default one for Social API implementers, we can remove HybridAuth for now.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.