Support from Acquia helps fund testing for Drupal Acquia logo

Comments

tim.plunkett created an issue. See original summary.

tim.plunkett’s picture

Status: Active » Needs review
FileSize
4.03 KB
DamienMcKenna’s picture

This needs to be in 8.x-4.0-beta1.

Status: Needs review » Needs work

The last submitted patch, 2: 2858212-panels-2.patch, failed testing.

tim.plunkett’s picture

Changing the composer.json to make sure that's not the problem...

Status: Needs review » Needs work

The last submitted patch, 5: 2858212-panels-5.patch, failed testing.

DamienMcKenna’s picture

The failures appear to be a problem with drupalci, specifically it's deleting modules after downloading them:

00:00:29.943 ---------------- Starting update_dependencies ----------------
00:00:29.944 Directory created at /var/lib/drupalci/workspace/jenkins-drupal8_contrib_patches-1009/ancillary/update_dependencies
00:00:29.944 composer.json changed by patch: recalculating depenendices
00:00:29.945 Determining composer branch: composer show --working-dir /var/lib/drupalci/workspace/jenkins-drupal8_contrib_patches-1009/source |grep 'drupal/panels ' |awk '{print $2}'
00:00:30.215 Removing project: ./bin/composer remove drupal/panels --ignore-platform-reqs --working-dir /var/lib/drupalci/workspace/jenkins-drupal8_contrib_patches-1009/source
00:00:36.409 Adding testing (require-dev) dependencies.
00:00:36.410 Removing dev dependencies: ./bin/composer remove drupal/page_manager --ignore-platform-reqs --working-dir /var/lib/drupalci/workspace/jenkins-drupal8_contrib_patches-1009/source
00:00:42.266 Removing dev dependencies: ./bin/composer remove drupal/panelizer --ignore-platform-reqs --working-dir /var/lib/drupalci/workspace/jenkins-drupal8_contrib_patches-1009/source

DamienMcKenna’s picture

tim.plunkett’s picture

Status: Needs work » Needs review
FileSize
6.33 KB
2.02 KB

Panelizer's integration with Panels lives in panelizer, so should the test. This might help resolve a circular dependency.

Status: Needs review » Needs work

The last submitted patch, 9: 2858212-panels-9.patch, failed testing.

tim.plunkett’s picture

Status: Needs work » Needs review
FileSize
348 bytes
4.42 KB

Let's talk about that interdiff in #2858488: Move PanelizerIntegrationTest from Panels to Panelizer, removing it from now since testbot won't notice the info.yml change in a patch anyway.

Trying a require-dev thing?

Status: Needs review » Needs work

The last submitted patch, 11: 2858212-panels-11.patch, failed testing.

  • tim.plunkett committed 360cfc7 on 8.x-4.x
    Issue #2858212 by tim.plunkett: Update PanelsIPELayoutForm to work with...
tim.plunkett’s picture

Status: Needs work » Fixed

Punting the rest to #2858552: Fix Panels composer.json, committing #2.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.