Everytime a module needs updating I use a make script to update all the modules, this also takes in dependencies defined in the modules themselves. Currently the make file in the services module points to the raw master branch of Spyc, instead of the 0.5.1 version specified in de rest_server_libraries_info function.

I wrote a patch to fix this problem and set the version to 0.5.1 as specified.

CommentFileSizeAuthor
#3 services-set_fixed_spyc_version-2858134-2.patch1.09 KBpdenooijer
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

pdenooijer created an issue. See original summary.

tyler.frankenstein’s picture

tyler.frankenstein CreditAttribution: tyler.frankenstein commented

Thank you for reporting this. It appears the patch file wasn't properly attached here, would you please attach it here for review?

pdenooijer’s picture

pdenooijer CreditAttribution: pdenooijer as a volunteer commented
FileSize
services-set_fixed_spyc_version-2858134-2.patch1.09 KB
pdenooijer’s picture

pdenooijer CreditAttribution: pdenooijer as a volunteer commented

@tyler.frankenstein, your too fast :D! I added the patch :).

tyler.frankenstein’s picture

tyler.frankenstein CreditAttribution: tyler.frankenstein commented
Status: Active » Fixed

Looks good to me, thank you!

pdenooijer’s picture

pdenooijer CreditAttribution: pdenooijer as a volunteer commented
Status: Fixed » Active

Nice thanks :)!

pdenooijer’s picture

pdenooijer CreditAttribution: pdenooijer as a volunteer commented
Status: Active » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.