Convert a library item into a paragraph

The part about not deleting the library item... Are we keeping the library item with the paragraph/s inside and clone a new paragraph when converting or take them out and leave an empty library item? For me the laving empty makes sense...

I guess we wait until #2862428: Add hook function for widget gets in.

Added some tests.

reroll

After committing #2862428: Add hook function for widget we can continue with this issue.

Just to run tests.

Needs reroll and changed to use alter hook function from paragraphs.

As discussed, this is IMHO not major.

rerolled patch

1. +++ b/modules/paragraphs_library/paragraphs_library.module
   @@ -143,3 +143,93 @@ function _paragraphs_library_count_usage(array $usage_data) {
   + * Implements hook_field_widget_form_alter().
   + */
   +function paragraphs_library_field_widget_form_alter(&$element, FormStateInterface $form_state, $context) {
   +  if ($context['widget']->getPluginId() == 'paragraphs') {
   +    $parents = $element['#field_parents'];
   +    $field_definition = $context['items']->getFieldDefinition();
   +    $field_name = $field_definition->getName();
   +    $widget_state = WidgetBase::getWidgetState($parents, $field_name, $form_state);
   +
   +    // Convert only library items.
   +    $paragraph = $widget_state['paragraphs'][$context['delta']];
   +    $paragraphs_entity = isset($paragraph) ? $paragraph['entity'] : FALSE;
   +    if ($paragraphs_entity && $paragraphs_entity->bundle() == 'from_library') {
   +      $id_prefix = implode('-', array_merge($parents, [$field_name, $context['delta']]));
   +      $element['top']['links']['library_to_paragraph'] = [
   +        '#type' => 'submit',
   +        '#value' => t('Convert to paragraph'),
   +        '#name' => strtr($id_prefix, '-', '_') . '_remove_library_item',
   

   this also needs to be converted to the new hook that we have now to alter operations on the paragraphs widget.

2. +++ b/modules/paragraphs_library/paragraphs_library.module
   @@ -143,3 +143,93 @@ function _paragraphs_library_count_usage(array $usage_data) {
   +
   +  // Inserting new element in the array.
   +  $widget_state = WidgetBase::getWidgetState($parents, $field_name, $form_state);
   +  $delta = $button['#delta'];
   +  $widget_state['original_deltas'] = array_merge($widget_state['original_deltas'], ['1' => 1]);
   +
   +  $paragraphs = [];
   +  if ($widget_state['paragraphs'][$delta]['entity']->hasField('field_reusable_paragraph')) {
   +    $library_items = $widget_state['paragraphs'][$delta]['entity']
   +      ->field_reusable_paragraph
   +      ->referencedEntities();
   +
   +    foreach ($library_items as $library_item) {
   +      foreach ($library_item->paragraphs->getValue() as $paragraph) {
   +        $paragraphs[] = $paragraph;
   +      }
   +    }
   +  }
   +
   +  $paragraph = \Drupal::entityTypeManager()
   +    ->getStorage('paragraph')
   +    ->loadRevision($paragraphs[0]['target_revision_id']);
   

   this is too generic and complicated, the reusable paragraph field can only have one value and the library can also only have one value, we do not need to loop or something like that. just access $library_item->get('paragraphs')->entity

   We are also not adding anything new, we just replace one.

This needs tests.

I guess we always replace one library paragraph with one effective paragraph entity. So we don't have any shifting of id's and weight in all the various states.

Addressed #14, improvements and test updates.

Most of the test fails from above are related to #2855309: Create ParagraphsTestBaseTrait..

Postponed until #2855309: Create ParagraphsTestBaseTrait. follow-up gets committed.

#2855309: Create ParagraphsTestBaseTrait. was committed. Reopening this issue.

Updating summary, this is not a less frequent requirement. In contrast, see above..

Needs reroll

+++ b/modules/paragraphs_library/src/Tests/ParagraphsLibraryItemTest.php
@@ -33,7 +33,7 @@ class ParagraphsLibraryItemTest extends ParagraphsExperimentalTestBase {
+    $this->addParagraphedContentType('paragraphed_test', 'field_paragraphs', 'entity_reference_paragraphs');

This should be tested with the experimental widget I think, so the second and third argument can be removed.

+++ b/modules/paragraphs_library/paragraphs_library.module
@@ -21,17 +21,37 @@ function paragraphs_library_paragraph_widget_dropbutton_alter(&$links, &$context
+      '#access' => $paragraphs_entity->access('update'),

I guess this will removed due to the new third party setting (allow_library_conversion)

Also, had some exceptions in the test about the ajax path

Connecting to template issue.

Rerolled, updates, addressed #22.

Checking CI results...

Applied suggestions from #25.