We can get rid of at least:

  • All results for closed issues
  • All non-current branch results
CommentFileSizeAuthor
#5 Screen Shot 2017-03-08 at 4.55.49 PM.png12.68 KBdrumm

Comments

drumm created an issue. See original summary.

drumm’s picture

Assigned: Unassigned » drumm

  • drumm committed 63525d6 on 7.x-3.x
    Issue #2857715: Handle displaying coding standards header when messages...
drumm’s picture

Once this commit is deployed, the coding standards section results will look like this after they have been removed from the pift_ci_job_checkstyle table.

drumm’s picture

StatusFileSize
new12.68 KB

Screenshot

drumm’s picture

Closed issues won’t clear too much yet:

mysql> SELECT count(1), fis.field_issue_status_value IN (1,2,4,8,13,14,15,16) open FROM pift_ci_job_checkstyle jc INNER JOIN pift_ci_job j ON j.job_id = jc.job_id AND j.target_type = 'file' INNER JOIN field_data_field_issue_status fis ON fis.entity_id = j.issue_nid GROUP BY open;
+----------+------+
| count(1) | open |
+----------+------+
|      713 |    0 |
|   100316 |    1 |
+----------+------+

That includes Fixed issues as “open”. That is 65,106 rows which would be cleaned after their 2 weeks is up.

Mixologic’s picture

So, just added #2859036: Provide coding standards delta checks - and Im thinking that coding standards isn't really data we need to persist for very long. Im thinking for patches, we might only need to keep the most recent results on an issue, or maybe even only stash that data for 3 or 6 months. And for branch tests, we possibly process the delta against the last result and provide x fixed, x new and *maybe* keep a graph, but probably not. That way a branch test only has the most recent results, and it doesnt particularly matter if they have daily tests with 10000 issues. we just store the most recent.

drumm’s picture

All non-current branch results

Rules I came up with:

  • For custom one-off tests, keep for 30 days to match what is shown on project’s automated testing tab.
  • For tests triggered on a schedule or commit, keep the most recent per-environment per-branch, and keep anything less than 24h old.

The results should be the same across environments, but they are all shown separately on the automated testing tab, so they are all expected to have results. I could see situations where having a little history (24h) would be useful for people.

  • drumm committed 7b71748 on 7.x-3.x
    Issue #2857715 by drumm: Clean coding standards results - branch tests
    
  • drumm committed c13c283 on 7.x-3.x
    Issue #2857715 by drumm: Clean coding standards results - closed issues
    
drumm’s picture

Status: Active » Fixed

This has been deployed to Drupal.org:

mysql> SELECT count(1) FROM pift_ci_job_checkstyle;
+----------+
| count(1) |
+----------+
|  7703181 |
+----------+
1 row in set (11.83 sec)

mysql> SELECT count(1) FROM pift_ci_job_checkstyle;
+----------+
| count(1) |
+----------+
|   617336 |
+----------+
1 row in set (0.30 sec)
Mixologic’s picture

Super awesome.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.