Problem/Motivation

While capitalising a comment in d6_file.yml I found that the same comment was not capitalised in d7_file.yml. It's because the sentence starts with the variable name. There is another comment with the same problem (in both files).

Proposed resolution

This can be resolved simply by re-jigging the sentence(s). It might also be possible to get the comment on a single line of <80 characters.

Remaining tasks

Re-jig the sentence(s).

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#8 2857681-8.patch1.88 KBjofitz
#8 interdiff-2-8.txt1.06 KBjofitz
#2 2857681-2.patch1.78 KBjofitz

Comments

Jo Fitzgerald created an issue. See original summary.

jofitz’s picture

jofitz
he/him
commented
Title: Comments not starting with a capital letter in d7_file.yml » Comments not starting with a capital letter in d6_file.yml & d7_file.yml
Assigned: jofitz » Unassigned
Status: Active » Needs review
StatusFileSize
new 2857681-2.patch1.78 KB

Rejigged the sentences to start with a capital letter, but retain the same meaning.

jofitz’s picture

jofitz
he/him
commented
Component: documentation » migration system
phenaproxima’s picture

phenaproxima
he/him
Primary language English
Location Massachusetts
commented
Status: Needs review » Reviewed & tested by the community

Nice.

quietone’s picture

quietone commented
Status: Reviewed & tested by the community » Needs work

Except that o

+++ b/core/modules/file/migration_templates/d7_file.yml
@@ -32,8 +32,7 @@ process:
+  # No need to migrate filesize - it is computed when file entities are saved.

Except that this sentence should match the one in the related patch. As pointed out by Jo Fitzgerald in #8

jofitz’s picture

jofitz
he/him
commented
Status: Needs work » Postponed

Let's wait until #2857502: Comment out migration of D6 file size to sync with D7. is in before finalising this - I can see the possibility of this going back and forth a few times (hopefully not!)

jofitz’s picture

jofitz
he/him
commented
Status: Postponed » Needs work

#2857502: Comment out migration of D6 file size to sync with D7. is now in so we're good to go!

jofitz’s picture

jofitz
he/him
commented
Status: Needs work » Needs review
StatusFileSize
new interdiff-2-8.txt1.06 KB
new 2857681-8.patch1.88 KB

Match the comments in d6_file.yml and d7_file.yml.

phenaproxima’s picture

phenaproxima
he/him
Primary language English
Location Massachusetts
commented
Status: Needs review » Reviewed & tested by the community

Nice and simple. I dig.

mikeryan’s picture

mikeryan
he/him
Primary language English
Location Pittsfield, MA, USA
commented
Issue tags: +migrate-d6-d8

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 8: 2857681-8.patch, failed testing.

jofitz’s picture

jofitz
he/him
commented
Status: Needs work » Reviewed & tested by the community

Tests are green - back to RTBC.

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented
Status: Reviewed & tested by the community » Fixed

Pedantry++ :)

Committed and pushed to 8.4.x and cherry-picked to 8.3.x. Thanks!

  • webchick committed 1512ec2 on 8.4.x 
    Issue #2857681 by Jo Fitzgerald, quietone: Comments not starting with a...

  • webchick committed 65b0767 on 8.3.x 
    Issue #2857681 by Jo Fitzgerald, quietone: Comments not starting with a...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.