Revision UUIDs are not unique using bean_uuid

I haven't had time to roll and test a patch for this but I've had a look through the code. The bean_uuid sub module needs to implement hook_bean_presave(). The hook should check if $bean->is_new_revision isset() to see if it is a new revision. If it is a new revision then $bean->vuuid needs to be assigned a new UUID by calling uuid_generate(). Something like this should do the trick:

<?php
/**
 * Implements bean_presave().
 */
function bean_uuid_bean_presave(&$bean) {
  if (isset($bean->is_new_revision()) {
    $bean->vuuid = uuid_generate();
  }
}

?>

Looks good

Agreed, this needs an update script.

Let's see if the bot is still misbehaving.

Fixing status

In case there are a large number of UUID-enabled entities in the system, I think uuid_sync_all() should be in its own update script.

I've reviewed the code and tested the patch in #13 in a complex site with the parent issue, and the module and update hooks resolve the issue for me.

Thinking through the logic here.. if uuid_sync_all() times out in bean_uuid_update_7203() what would happen? IIRC the process will fail and the next time the updates are ran it'll try to do the same update only with fewer records to go. Right?

Now that we have support for Devel (Contrib) Generate via #2894053 I'm going to see about manually testing this with a bazillion beans.

A site with a bazillion beans (fun to say) would be running this via drush anyway. PHP CLI default timeout is 0 so it would just run forever. I'm committing this. Good work!

Thanks for all the work!

https://www.drupal.org/commitlog/commit/22232/f90a5fbbed6871f6e319eef37b...