Closed (fixed)
Project:
Metatag
Version:
7.x-1.x-dev
Component:
Code
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
1 Mar 2017 at 19:00 UTC
Updated:
17 Jul 2017 at 18:19 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
arosboro commentedProblem:
"/sites/default/files/filename-(1).jpeg" becomes "/sites/default/files/filename-%281%29.jpeg" due to sanitization. Panels uses % as an indication of a contextual keyword.
The attached patch minimizes this by including the first part of the keyword in the search pattern before doing a context keyword substitution.
Comment #3
arosboro commentedComment #4
arosboro commentedThe previous patch had issues. Please review attached patch #4.
Comment #5
damienmckennaOH! Hah! Yeah, I bet that was a tricky one to track down :)
Lets see about adding a test to confirm the behavior.
Comment #6
arosboro commentedI've attached the patch with metatag_panels/tests included. The pages_default include has been updated with user context, and the abstract metatag is used with the string "http://www.example.com/user/%user:uid/full-bio-%281%29.pdf". Hoping to receive "http://www.example.com/user/1/full-bio-(1).pdf" after processing the context keyword replacements and decoding the url encoded value.
Comment #8
arosboro commentedForgot to include the test in the manifest
Comment #9
arosboro commentedComment #11
arosboro commentedI ran this one locally and cleaned up the errors with the test. metatag_hreflang passes as well for me.
Comment #13
damienmckennaNot sure why hreflang is failing..
So I think the test could be merged into the main test file, ultimately it's just one test method. Thanks.
Comment #14
arosboro commentedMetatag Href with Entity Translation was failing because upstream or other code changes have lead to the default form language being set to 'en' and the index of the locale fields being changed to 'default' instead of 'value'.
Comment #15
arosboro commentedHi Damien, I found the issue with metatag href... the form structure has changed recently. I'll look at adding these back into metatag_panels.test now.
Comment #16
arosboro commentedGood looks like everything's passing. Here's your revised patch with a single method in in the metatag_panels/tests/metatag_panels.test path.
Comment #17
damienmckennaLets deal with the Entity Translation changes in #2857982: Fixed tests in 7.x-1.x branch, so this can focus on the bugs in the Panels handling.
Comment #18
arosboro commentedAttached patch includes metatag_panels related test methods and fix for this issue.
Comment #20
damienmckennaNow that #2857982 is fixed (thanks for that, btw) lets rerun the tests.
Comment #21
arosboro commentedDamien, Thanks for being on top of this over your weekend :)
Comment #22
arosboro commentedThis has passed tests, just wondering if it can be included in a release anytime soon or if we are waiting for more RBTC feedback
Comment #24
damienmckennaCommitted. Thanks.