CommentFileSizeAuthor
#2 salesforce-pull_record_types_for_multiple-2857080-1.patch1.55 KBaaronbauman

Comments

aaronbauman created an issue. See original summary.

aaronbauman’s picture

aaronbauman
he/him
commented
Status: Active » Needs review
StatusFileSize
new salesforce-pull_record_types_for_multiple-2857080-1.patch1.55 KB

Wrangling record types needs to happen in the same loop during which fields are collected inside salesforce_pull_get_pull_query()

  • tauno committed d659812 on 7.x-3.x authored by aaronbauman 
    Issue #2857080 by aaronbauman: Given multiple mappings for the same...
tauno’s picture

tauno commented
Status: Needs review » Fixed
asherry’s picture

asherry commented

Hi Aaron, this is related to a patch I've been working on but haven't heard anything back about. #2694245: Multiple mapping for the same drupal entity I'm curious why the mapping name isn't stored in each queue item.

It seems a bit odd to me that for each queue item we cycle through all the mappings to see which one has to do with a particular record (object type), after doing the exact same thing to populate the queue in the first place.

I do have to update the patch, and I'm currently working on that, but it'd be nice to get some higher level feedback in case there is a reason I'm missing and I shouldn't bother. At the very least I'd like to DRY out the code, like what you did here #2642090: DRY refactor for salesforce_pull_process_records(), and I did in that same patch, but both need to be updated.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.