SendGrid API Key is a required field, so I think it would make sense to have a runtime error (ie. a "nag" function) when the module is installed to prompt the user to enter the key.

CommentFileSizeAuthor
#2 sendgrid-api_key_runtime_error-2856764-1.patch1.4 KBaaronbauman

Comments

aaronbauman created an issue. See original summary.

aaronbauman’s picture

aaronbauman
he/him
commented
Status: Active » Needs review
StatusFileSize
new sendgrid-api_key_runtime_error-2856764-1.patch1.4 KB

In this patch:
- implement hook_requirements in sendgrid_integration.install
- if "api key" has not been entered, return a REQUIREMENT_ERROR
- if "api key" has been saved, return a REQUIREMENT_OK

perignon’s picture

perignon commented

Cool I want to backport this to 7.x too.

  • Perignon committed a392f39 on 8.x-1.x authored by aaronbauman 
    Issue #2856764 by aaronbauman: Add a runtime hook requirements to set a...
perignon’s picture

perignon commented
Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.