Closed (fixed)
Project:
GA Push
Version:
8.x-1.x-dev
Component:
Code
Priority:
Normal
Category:
Feature request
Assigned:
Unassigned
Reporter:
Created:
28 Feb 2017 at 09:40 UTC
Updated:
29 Jun 2017 at 14:25 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
omarlopesinoHere is a patch adding the new method.
Rules action integration is added too, it allows add datalayer event name. The field will only appears if datalayer method is selected, or default method is selected and is set up as datalayer.
Can you review this, if you please? Thanks!!
Comment #3
crzdev commentedWorking as expected, thanks for the patch!
Comment #4
crzdev commentedComment #5
gedur commentedComment #7
gedur commentedThanks, commited.
This patch needs to be ported to D8
Comment #8
igorik commentedHi, this looks exactly as what I was looking for.
I moved from GA module to Google Tag Manager module.
So with this patch I don't need GA module for using GA push module?
Thank you.
Comment #9
omarlopesinoHi igorik.
Now in dev version of ga push you need only enable google analytics because is a module's dependency.
If you just enable GA module but don't set up, it won't send ga events. So you won't have any problem to integrate ga push datalayer events with Google Tag Manager.
Comment #10
igorik commentedThank you, it works perfectly.
Comment #11
crzdev commentedHere is the patch with the port to 8.x version. It will include method selector implementation in all rules actions (very useful in this case and also implemented into 7.x version).
Please test it, thanks!
Comment #13
tunicGood! Thanks for the patch, it has been committed.