Implement consecutive characters constraint

+++ b/password_policy_consecutive/src/Plugin/PasswordConstraint/Consecutive.php
@@ -0,0 +1,85 @@
+      $validation->setErrorMessage($this->t('Password must have fewer than @max identical characters.', ['@max' => $max]));

Needs 'consecutive' otherwise it's ambiguous. I.e. '@max consecutive identical characters'.

This looks good.

Has this been functionally tested yet? I don't often move issues to RTBC until it's been done

Code review comments:

1. class Consecutive - Can this be ConsecutiveCharacters? This would mimic the convention used on other constraints.

And, really awesome job with the automated tests. I would love to see you submit a patch that refactors the tests of the other constraints :)

@nerdstein Sorry I didn't make it clear, but yes I tested this through the UI as well as reviewing the code.

@acbramley has made the changes requested in #8 so moving back to RTBC.

$form_state->setErrorByName('max_consecutive_characters', $this->t('The number of character types must be higher than 1 otherwise all passwords will fail.'));

Shouldn't "character types" instead be "consecutive identical characters"?

Also, I am wondering if it should be mentioned somewhere this is case insensitive. I personally was not sure whether "s" and "S" would be considered "identical". Is the case insensitivity non-obvious to anyone else or just me?

Fix for #13 looks good.

@AohRveTPV this is case sensitive, so "ss" will trigger a password fail (if max_consecutive_characters == 2) while "sS" will not.
I'd say adding a ", case sensitive." note onto the message "Password must have fewer than 2 consecutive identical characters." should help clear that up. Marking as Needs work for that.

Great, thanks!

I ran Coder on the patched code and it gave a warning:

FILE: ...password_policy_consecutive/password_policy_consecutive.info.yml                   
|  ----------------------------------------------------------------------                      
|  FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE                                               
|  ----------------------------------------------------------------------                      
|   7 | WARNING | All dependencies must be prefixed with the project                           
|     |         | name, for example "drupal:"                                                  
|  ---------------------------------------------------------------------- 

I'll plan to make the fix later, but an updated patch is welcome. Haven't yet reviewed/tested the patch.

Well spotted @AohRveTPV, thanks @acbramley.

This looks good, thank you.

I implemented this constraint for 7.x-1.x. A website I work on needed it. Do not plan to add it to 7.x-1.x, just wanted to share it here.

Inadvertently uploaded a case-insensitive version of this constraint in #24.

Here is a 7.x-1.x implementation of the constraint that should behave the same as the 7.x-2.x and 8.x-3.x implementations.