Problem/Motivation

The Quickedit overlay does not reposition itself automatically when the orientation of the toolbar is adjusted without any other changes to the page. This was discovered while reviewing, #2270269: Reduce animation delays.

The incorrect behavior in action,

Proposed resolution

Listen to the drupalViewportOffsetChange.quickedit event and reposition the Quickedit overlay accordingly.

CommentFileSizeAuthor
quickedit-viewport-offset.patch1.11 KBGrandmaGlassesRopeMan
misposition.gif423.19 KBGrandmaGlassesRopeMan

Comments

drpal created an issue. See original summary.

GrandmaGlassesRopeMan’s picture

GrandmaGlassesRopeMan
he/him
Primary language English
Location 🌎
commented
Issue tags: +JavaScript

Status: Needs review » Needs work

The last submitted patch, quickedit-viewport-offset.patch, failed testing.

GrandmaGlassesRopeMan’s picture

GrandmaGlassesRopeMan
he/him
Primary language English
Location 🌎
commented
Status: Needs work » Needs review
wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Status: Needs review » Reviewed & tested by the community

Great find, and for once, a wonderfully simple fix thanks to us just being able to listen to one more event.

xjm’s picture

xjm
she/her
Primary language English
commented
Version: 8.4.x-dev » 8.3.x-dev
Status: Reviewed & tested by the community » Patch (to be ported)

Even I can understand this patch! That's a clean fix indeed.

Committed to 8.4.x. I think this bugfix is also patch-safe. Since we are in RC, though, marking PTBP against 8.3.x for now. (We were going to do an RC branch but haven't gotten that working yet, so falling back to the 8.2.x strategy for it.)

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Patch (to be ported) » Fixed

@catch, @cilefen, @xjm and I decided that patch rules would apply to 8.3.x until RC2 so this is eligible for backport.

Committed fd93a4a and pushed to 8.3.x. Thanks!

  • alexpott committed fd93a4a on 8.3.x authored by xjm 
    Issue #2856364 by drpal, Wim Leers: Reposition Quickedit overlay on...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.