Problem/Motivation

#2770921: Feb 21st: Convert chunk of WTB to BTB by just moving classes, changing use statements adding traits has transformed a lot of WTB tests to BTB tests, which caused moving the tests to different location / namespace and therefore the LockFunctionalTest is not anymore found in RedisLockFunctionalTest.

Proposed resolution

Use the new namespace of the LockFunctionalTest.

Remaining tasks

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#8 class-2856241-8-interdiff.txt4.43 KBBerdir
#8 class-2856241-8.patch9.76 KBBerdir
#7 class-2856241-7.patch6.47 KBBerdir
#4 2856241-4.patch727 byteshchonov
#2 2856241-2.patch507 byteshchonov
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

hchonov created an issue. See original summary.

hchonov’s picture

hchonov
Primary language Bulgarian
Location 🇪🇺🇩🇪🇧🇬
CreditAttribution: hchonov at bio.logis Genetic Information Management GmbH commented
Status: Active » Needs review
FileSize
2856241-2.patch507 bytes
Berdir’s picture

Berdir
Primary language German
Location Switzerland
CreditAttribution: Berdir at MD Systems GmbH commented
Status: Needs review » Needs work

Thanks but our test needs to move as well then. I suggest you make a MR against https://github.com/md-systems/redis/, that is able to run the tests.

hchonov’s picture

hchonov
Primary language Bulgarian
Location 🇪🇺🇩🇪🇧🇬
CreditAttribution: hchonov at bio.logis Genetic Information Management GmbH commented
Status: Needs work » Needs review
FileSize
2856241-4.patch727 bytes
hchonov’s picture

hchonov
Primary language Bulgarian
Location 🇪🇺🇩🇪🇧🇬
CreditAttribution: hchonov at bio.logis Genetic Information Management GmbH commented

https://github.com/md-systems/redis/pull/23

P.S. this is the correct PR.

hchonov’s picture

hchonov
Primary language Bulgarian
Location 🇪🇺🇩🇪🇧🇬
CreditAttribution: hchonov at bio.logis Genetic Information Management GmbH commented

The problem with this issue is not that I cannot run the redis tests, it is that I cannot run my custom phpunit tests because of the error thrown because of redis.

Berdir’s picture

Berdir
Primary language German
Location Switzerland
CreditAttribution: Berdir at MD Systems GmbH commented
FileSize
class-2856241-7.patch6.47 KB

The last commit should now hopefully pass, then I'll commit this.

Berdir’s picture

Berdir
Primary language German
Location Switzerland
CreditAttribution: Berdir at MD Systems GmbH commented
Title: Class 'Drupal\system\Tests\Lock\LockFunctionalTest' not found in RedisLockFunctionalTest » Update test for 8.3.x and convert to PHPUnit
FileSize
class-2856241-8.patch9.76 KB
class-2856241-8-interdiff.txt4.43 KB

Now it passes :)

  • Berdir committed 00d5173 on 8.x-1.x 
    Issue #2856241 by Berdir, hchonov: Update test for 8.3.x and convert to...
Berdir’s picture

Berdir
Primary language German
Location Switzerland
CreditAttribution: Berdir at MD Systems GmbH commented
Status: Needs review » Fixed

Committed. Downside is that it will now fail with 8.2.x, but I'll wait with a new release until 8.3.x is stable.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.