The Auto Label tab is not displayed for Media Entity Bundles (NOT Media-in-core since Drupal core 8.4). It would be nice to beable to auto label media.

Comments

TrailWiki created an issue. See original summary.

geek-merlin’s picture

Title: Auto Label tab not displayed for Media Bundles » Auto Label tab not displayed for Media-Entity Bundles
Issue summary: View changes
Status: Active » Needs review
StatusFileSize
new1.65 KB

This was introduced in #2755445: Auto Entity label does not set entity labels and breaks contrib modules, and i think "only support core entities" was too narrow.

In the long run we should look like devel or field_tools provide any entity with a task.
For now let's just remove the disabling code.

Patch flying in.

geek-merlin’s picture

Of course this patch does not remedy what was the original reason of the code but it might be a start and fixes the problem for me.

geek-merlin’s picture

Title: Auto Label tab not displayed for Media-Entity Bundles » Auto Label tab condition broken
Priority: Normal » Major
StatusFileSize
new1.92 KB

Looks like the condition when a autolabel makes sense was broken in the first place and restricting on core entities was a mere hack.
The right condition is ConfigEntityBundle.

Patch flying in.

gg24’s picture

Status: Needs review » Needs work

Hi @axel.rutz,

I went through the patch and comment mentioned above and can clearly see that initially automatic entity label module was only supporting core modules not contrib modules and I appreciate that you took this initiative here and after applying the patch I am able to see the auto label tab too for media content as well but when I try to set the auto label for media Image I do not it working so my point here is once we are complete with the functionality than only we should move this code to code repo, just enabling the tab will be confusing as of now. Let me know if I am not clear here.

Note:- This patch ensures that auto label tab is visible for media content but functionality is not complete yet.

Thanks!

geek-merlin’s picture

Status: Needs work » Needs review
Related issues: +#2923876: Broken when provider !=entityTypeId

Yes rite! I fixed that bug in #2923876: Broken when provider !=entityTypeId.

  • axel.rutz authored a40d5ad on 8.x-2.x
    Issue #2856152 by axel.rutz: Auto Label tab not displayed for Media-...
colan’s picture

Status: Needs review » Fixed

Thanks! (I especially like patches where I can use git am!!)

geek-merlin’s picture

Cool this is in now!

geek-merlin’s picture

> Thanks! (I especially like patches where I can use git am!!)

Nice you like that too. You can link people to the docs page i created: Making maintainer-friendly "git am" single and multi-patches | Drupal.org

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.