In this commit which was marked "Panels 3.9 Code Cleanup" I think a function was removed that shouldn't have been.

http://cgit.drupalcode.org/panels/commit/?id=f400a1d0d025262d05d497cf326...

-  function clone_pane($pid) {
-    $pane = clone $this->content[$pid];
-    $pane->uuid = ctools_uuid_generate();
-    return $pane;
-  }
-
CommentFileSizeAuthor
#9 panels_3_9_code_cleanup-2856088-9.patch1.08 KBjoseph.olstad
#5 panels_3_9_code_cleanup-2856088-5.patch1.46 KBsylus

Comments

sylus created an issue. See original summary.

sylus’s picture

sylus commented
Related issues: +#2855979: Missing method clone_pane() error when cloning variant
sylus’s picture

sylus commented
Title: Panels 3.9 Code Cleanup removed clone_pane function() » Panels 3.9 Code Cleanup removed clone_pane() function
sylus’s picture

sylus commented
Issue summary: View changes
sylus’s picture

sylus commented
Status: Active » Needs review
StatusFileSize
new panels_3_9_code_cleanup-2856088-5.patch1.46 KB
sylus’s picture

sylus commented
Issue summary: View changes
das-peter’s picture

das-peter commented
Status: Needs review » Reviewed & tested by the community

Just stumbled over this too. This method is still used by panels_display::duplicate_pane()
I guess we should bring that back in and refactor if we want to remove it.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Status: Reviewed & tested by the community » Needs work
Parent issue: » #2850154: Plan for Panels 7.x-3.10

It needs to be a "public function".

joseph.olstad’s picture

joseph.olstad
Primary language French
commented
Status: Needs work » Reviewed & tested by the community
StatusFileSize
new panels_3_9_code_cleanup-2856088-9.patch1.08 KB

made the function public

joelpittet’s picture

joelpittet
he/him
Primary language English
Location Vancouver
commented
Status: Reviewed & tested by the community » Fixed

Thanks @sylus and @joseph.olstad I've committed this to the dev branch for the next release.

  • joelpittet committed f9f0eaa on 7.x-3.x authored by sylus 
    Issue #2856088 by sylus, joseph.olstad, das-peter, DamienMcKenna: Panels...
joseph.olstad’s picture

joseph.olstad
Primary language French
commented

cool, thanks joelpittet!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.