Removed the deprecated method from the Quick Tabs module code base.

CommentFileSizeAuthor
#8 urlinfo_deprecated-2856087-8.patch1.45 KBgg24
#6 urlinfo_deprecated-2856087-5.patch952 bytesgg24
#2 Urlinfo_deprecated-2856087-2.patch1.06 KBMunavijayalakshmi

Comments

Munavijayalakshmi created an issue. See original summary.

Munavijayalakshmi’s picture

Munavijayalakshmi commented
StatusFileSize
new Urlinfo_deprecated-2856087-2.patch1.06 KB
Munavijayalakshmi’s picture

Munavijayalakshmi commented
Status: Active » Needs review
Munavijayalakshmi’s picture

Munavijayalakshmi commented
Assigned: Munavijayalakshmi » Unassigned
gg24’s picture

gg24 commented
Assigned: Unassigned » gg24
Status: Needs review » Needs work

In newer code base version 8.x-3.x-dev file 'src/QuicktabListBuilder.php' does not exist anymore. It has renamed to 'src/QuickTabsInstanceListBuilder.php'.
Hence re-rolling the patch.

Thanks!

gg24’s picture

gg24 commented
Assigned: gg24 » Unassigned
Status: Needs work » Needs review
StatusFileSize
new urlinfo_deprecated-2856087-5.patch952 bytes

Re-rolled the patch against version 8.x-3.x-dev.
Please review.

Thanks!

jaykandari’s picture

jaykandari
Primary language Hindi
commented
Status: Needs review » Needs work

@gg24 : #6 looks good implemented changes in 3 places. However I see one more instance where this needs to apply. could you pls fix this as well.
src/Form/QuickTabsInstanceDuplicateForm.php:79

gg24’s picture

gg24 commented
Status: Needs work » Needs review
StatusFileSize
new urlinfo_deprecated-2856087-8.patch1.45 KB

Here is the updated Patch.
Please review.

Thanks!

jaykandari’s picture

jaykandari
Primary language Hindi
commented
Status: Needs review » Reviewed & tested by the community

@gg24: Looks Good !! Implemented all 4 changes. Moving to RTBC.
Thanks!

systemick’s picture

systemick commented
Status: Reviewed & tested by the community » Fixed

Patch in #8 has been committed into the dev branch.

systemick’s picture

systemick commented
Status: Fixed » Closed (fixed)