Proposed output for results, and associated reports.

Ive found it useful for when creating gateway plugins

devel ouput

CommentFileSizeAuthor
#12 interdiff-2856048-sms-devel-result-reports-output-10-12.txt2.19 KBdpi
#12 2856048-sms-devel-result-reports-output-12.patch14.39 KBdpi
#10 2856048-sms-devel-result-reports-output-10.patch14.35 KBdpi
#8 2856048-sms-devel-result-reports-output-8.patch14.27 KBdpi
#8 interdiff-2856048-6-8.txt836 bytesdpi
#6 2856048-sms-devel-result-reports-output-5.patch14.27 KBdpi
#5 interdiff-2856048-5.txt718 bytesdpi
#2 2856048-sms-devel-result-reports-output-2.patch14.26 KBdpi
devel_output.jpg198.55 KBdpi

Comments

dpi created an issue. See original summary.

dpi’s picture

dpi
Location Perth, Australia
commented
Status: Active » Needs review
StatusFileSize
new 2856048-sms-devel-result-reports-output-2.patch14.26 KB

PR at https://github.com/dpi/smsframework/pull/70

  • No functional changes. Other than an "enable verbose output" checkbox (default: checked).
  • Refactored a bit since branch originally created earlier this year.
  • Added tests.
  • Fixed deprecation warnings in the test modified: SmsDevelMessageTest
  • Added sms_devel to phpunit.xml.dist so PHPUnit picks up submodule test.
dpi’s picture

dpi
Location Perth, Australia
commented

Status: Needs review » Needs work

The last submitted patch, 2: 2856048-sms-devel-result-reports-output-2.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

dpi’s picture

dpi
Location Perth, Australia
commented
Status: Needs work » Needs review
StatusFileSize
new interdiff-2856048-5.txt718 bytes

quick fix

dpi’s picture

dpi
Location Perth, Australia
commented
StatusFileSize
new 2856048-sms-devel-result-reports-output-5.patch14.27 KB

Status: Needs review » Needs work

The last submitted patch, 6: 2856048-sms-devel-result-reports-output-5.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

dpi’s picture

dpi
Location Perth, Australia
commented
Status: Needs work » Needs review
StatusFileSize
new interdiff-2856048-6-8.txt836 bytes
new 2856048-sms-devel-result-reports-output-8.patch14.27 KB

try again.

almaudoh’s picture

almaudoh commented
Status: Needs review » Needs work

Failures in D8.5 due to: 

  * Tests the message form.
  *
  * @group SMS Framework
- * @group legacy
  */

@group legacy should not be removed

dpi’s picture

dpi
Location Perth, Australia
commented
Status: Needs work » Needs review
StatusFileSize
new 2856048-sms-devel-result-reports-output-10.patch14.35 KB

reroll, cs fix, above feedback

Status: Needs review » Needs work

The last submitted patch, 10: 2856048-sms-devel-result-reports-output-10.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

dpi’s picture

dpi
Location Perth, Australia
commented
StatusFileSize
new 2856048-sms-devel-result-reports-output-12.patch14.39 KB
new interdiff-2856048-sms-devel-result-reports-output-10-12.txt2.19 KB

Cs and test fix.

dpi’s picture

dpi
Location Perth, Australia
commented
Status: Needs work » Needs review
dpi’s picture

dpi
Location Perth, Australia
commented

  • dpi committed 3513604 on 8.x-1.x 
    Issue #2856048 by dpi, almaudoh: Add result and report output to sms...
dpi’s picture

dpi
Location Perth, Australia
commented
Assigned: dpi » Unassigned
Status: Needs review » Fixed

Committed 💥

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.