Deprecated methods and function

Can you please link the change notices for each of the issues in the description?

Also all changes are to dev.

Hello Guys,
I have updated patch, because there were two critical issues were causing failing tests:
1st is about loading entity form display
2nd is about the way how drupal_render_children() was replaced
Additionally I have replaced \Drupal::database()->query() (where SELECT is called) with \Drupal::database()->select(), since that is more Drupal way.
Please review the patch,

And here is patch to comment above (#6)

Testing steps are as follows:-

1. Enabled Captcha Module.
2. Enabled node_edit_form captcha point.
3. Changed captcha settings accordingly.
4. Created a new anonymous user.
5. Added edit and add node permission to it.
6. Tried creating a new node and tried editing the node from this particular user.
7. If i put wrong captcha, it gives error to me.
8. Everything works as expected.

Attaching screenshot for the captcha here too. #7 Patch works as expected. Issuing RTBC to this.

Thanks!

Avoid static method call inside Class method, use dependency injection instead.

I have updated patch. Added dependency injections to Captcha, CaptchaCachedSettingsSubscriber, CaptchaExamplesForm, CaptchaPointForm and CaptchaSettingsForm classes even that was not requested initially.
@gg24, @bapi_22 feel free to check it now.
P.S. locally tests are run without issues.

I've committed the changes so the patches aren't so massive. So it should be easier to tweak if necessary.

Hi alunyov,

Looks good Now.
As REQUEST_TIME is deprecated, so try to use \Drupal::time()->getRequestTime() instead.

Thanks

Hey bapi_22,
Here is new patch to replace deprecated REQUEST_TIME. Tests run locally fine.

Marking the issue as 'Needs review'

#14 Looks good
+1 to RTBC