No entity on insert for a PULL_PRESAVE Subscriber

I believe this is happening because the contructor for SalesForcePullEvent calls the getMappedEntity() method of MappedObject.

  public function __construct(MappedObjectInterface $mapped_object, $op) {
    $this->mapped_object = $mapped_object;
    $this->entity = $mapped_object->getMappedEntity();
    $this->mapping = $mapped_object->getMapping();
    $this->op = $op;
  }

But the getMappedEntity() method presumes that there is an entity_id, which there wouldn't be on an insert as $entity->save() hasn't yet been executed:

  /**
   * @return EntityInterface
   */
  public function getMappedEntity() {
    $entity_id = $this->entity_id->value;
    $entity_type_id = $this->entity_type_id->value;
    return $this
      ->entityManager()
      ->getStorage($entity_type_id)->load($entity_id);
  }

However, we know that the drupal_entity member variable gets populated by the foreach that loops over the fields in the pull method of MappedObject. So I've modified the getMappedEntity() function as follows. I don't know if this is the best way to do this or I'd submit a patch with the changes.

  /**
   * @return EntityInterface
   */
  public function getMappedEntity() {
    $entity_id = $this->entity_id->value;
    if(!$entity_id) {
      // this is a new entity...
      return $this->drupal_entity;
    }
    else {
      $entity_type_id = $this->entity_type_id->value;
      return $this
        ->entityTypeManager()
        ->getStorage($entity_type_id)->load($entity_id);
  }

Will do Aaron. I'll post it in this thread however there are also some other changes I've made.

Aaron, attached is a patch that does several things:

1. Integrates the aforementioned tweak to the getMappedEntity() function
2. A PULL_POSTSAVE mechanism. I realize the hook_entitiy_update and hook_entity_insert could fulfill this role however there are instances where I only want to act on an entity that's been created via a salesforce_pull. For example, we're using this module to create commerce_product and commerce_product_variation entities. After a commerce_product_variation has been created, we need to add that variation to an appropriate product. But I do not want this firing every time a commerce_product_variation entity is created, only when one has been created via salesforce_pull.
3. A little cleanup on the example Subscriber. I don't know if it would actually run, I didn't test it. Mainly I just resolved issues that PHPStorm was squawking about

1. So you're saying used a hook_entity_update/hook_entity_insert to look for the MappedObject entity save and react to that? A couple things I like about having a SubscriberEvent for PULL_POSTSAVE is that it keeps all my code in the same Subscriber file and able to use a Trait I'd developed for other activities. As opposed to having some code in the Subscriber class and some in a .module file.

2. Ah, yes, I forgot to mention that. When I try to use kint() or ksm() to take a look at the object, it was failing due to the lack of a getIterator() method. It never really worked so I'll remove it from the code.

3. Will do.

1. Fair enough. I removed the PULL_POSTSAVE modification from the attached patch.

2. Yes, I've got that max level set. Thank you for the steer to vardumper.

Attached patch has:

1. SalesforceExampleSubscriber.php: needed a few 'use' statements for the example functions.
2. MappedObject.php: update to getMappedEntity that kicked this all off
3. PullBase.php: there's an attempt to log an Exception outside the scope of a try/catch statement. I couldn't see that an Exception was thrown from deeper function so I moved it inside the catch statement.
4. salesforce.api.php: very minor issue, PHPStorm want to see empty brackets after a function declaration. This file of course never gets called but...I don't like red squigglies in my IDE> :)