DrupalCI now uses PHP_CodeSniffer to provide checkstyle results about code tested on Drupal.org. We are shortly going to be adding ESLint and CSSLint results as well (see above.) This information is presently only displayed through the 'view results' link on any tests, in the Build Artifacts of any test. We want to more helpfully link to or display this information directly on Drupal.org.

Comments

hestenet created an issue. See original summary.

drumm’s picture

drumm
he/him
Location NY, US
CreditAttribution: drumm at Drupal Association commented
Assigned: Unassigned » drumm

  • drumm committed 8757f18 on 7.x-3.x 
    Issue #2854700: Display checkstyle results
drumm’s picture

drumm
he/him
Location NY, US
CreditAttribution: drumm at Drupal Association commented
Status: Active » Fixed
Issue tags: +needs drupal.org deployment

The basics of this are ready to deploy. There will be a few followups, like #2851916: Expose phpcs patches to comment stream

  • drumm committed 178bbb6 on 7.x-3.x 
    Issue #2854700: Copyediting
  • drumm committed 5b19358 on 7.x-3.x
    Issue #2854700: Trim off project directory from path
drumm’s picture

drumm
he/him
Location NY, US
CreditAttribution: drumm at Drupal Association commented
Issue tags: -needs drupal.org deployment

This has been deployed, https://www.drupal.org/pift-ci-job/607443 is the first result with coding standards messages.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

jonathan1055’s picture

jonathan1055 CreditAttribution: jonathan1055 as a volunteer commented

Sorry this is late and apologies to everyone following this issue, but I just want to thank drumm for this excellent work. It is a great help for developers and maintainers, and we now have a real incentive to get our code clean and keep it clean. I have now completely cleaned my module and will insist that all patches are clean before I commit them. Thank you again.
Jonathan