This was brought to me attention by the UC Berkeley accessibility team: in testing with a screen reader, they determined that it would be better accessibility of the message about the number of search results appeared as the page title and H1, rather than an H2 in the page.

Before:

After:

CommentFileSizeAuthor
#4 panopoly_test-results-page-title-2854334-3.patch983 bytesdsnopek
#3 panoploy_test-results-page-title-2854334-3.patch983 bytesdsnopek
#2 panopoly_search-results-page-title-2854334-2.patch2.98 KBdsnopek
Selection_025.png146.94 KBdsnopek
Selection_024.png145.99 KBdsnopek

Comments

dsnopek created an issue. See original summary.

dsnopek’s picture

dsnopek
he/him
Primary language English
Location USA
commented
Status: Active » Needs review
StatusFileSize
new panopoly_search-results-page-title-2854334-2.patch2.98 KB

Here's a patch to implement! This probably needs updates to the tests -- gonna check that out next

EDIT: Here's a build on Travis: https://travis-ci.org/panopoly/panopoly/builds/203613466

dsnopek’s picture

dsnopek
he/him
Primary language English
Location USA
commented
StatusFileSize
new panoploy_test-results-page-title-2854334-3.patch983 bytes

Here's a patch to fix the test issues. I'll try on Travis again in a moment

EDIT: Here's the new test on Travis https://travis-ci.org/panopoly/panopoly/builds/203856500

dsnopek’s picture

dsnopek
he/him
Primary language English
Location USA
commented
StatusFileSize
new panopoly_test-results-page-title-2854334-3.patch983 bytes

Blergh. Our test script failed because I misspelled the patch now. Here's take 2!

EDIT: Here's the Travis build: https://travis-ci.org/panopoly/panopoly/builds/203859089

EDIT: That one didn't generate right -- here's another: https://travis-ci.org/panopoly/panopoly/builds/203864970

cboyden’s picture

cboyden commented
Status: Needs review » Reviewed & tested by the community

This is looking great, thanks @dsnopek! I tested with facets/filters and the results summary in the title updates to reflect the current number of matching results when you choose a facet.

  • dsnopek committed 1ac86f4 on 7.x-1.x 
    Update Panopoly Search and Test for Issue #2854334 by dsnopek, cboyden:...
dsnopek’s picture

dsnopek
he/him
Primary language English
Location USA
commented
Status: Reviewed & tested by the community » Fixed

Thanks! Committed :-)

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.