The Checkbox element has this:

'#process' => array(
  ...
  array($class, 'processGroup'),
 ),
'#pre_render' => array(
  ...
  array($class, 'preRenderGroup'),
 ),

so does the Textfield and the Datetime element.

But Select does not. Is there any good reason? Adding the calls in the form definition makes things work instantly, so there is a workaround, but why not add this to the element itself?

CommentFileSizeAuthor
#9 Screen Shot 2019-06-13 at 1.27.33 PM.png90.6 KBsean_e_dietrich
#9 Screen Shot 2019-06-13 at 11.39.49 AM.png70.09 KBsean_e_dietrich
#9 Screen Shot 2019-06-13 at 11.39.31 AM.png269.97 KBsean_e_dietrich
#5 2854166.patch626 bytesgrathbone

Comments

ChristianAdamski created an issue. See original summary.

christianadamski’s picture

christianadamski commented
Title: Add #group handling to Select fields » Add #group handling to Select form/render element

Version: 8.4.x-dev » 8.5.x-dev

Drupal 8.4.0-alpha1 will be released the week of July 31, 2017, which means new developments and disruptive changes should now be targeted against the 8.5.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.5.x-dev » 8.6.x-dev

Drupal 8.5.0-alpha1 will be released the week of January 17, 2018, which means new developments and disruptive changes should now be targeted against the 8.6.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

grathbone’s picture

grathbone commented
Status: Active » Needs review
StatusFileSize
new 2854166.patch626 bytes

Ran into this issue trying to figure out why the "select" Form Elements weren't going into their correct groups on Views arguments.

Wrote a patch to add the default methods.

Also, looks like this could be solved globally, so may want to watch this ticket.
https://www.drupal.org/project/drupal/issues/2190333

grathbone’s picture

grathbone commented
Related issues: +#2190333: Make #group FAPI / render feature work on all form/render #types out of the box

Version: 8.6.x-dev » 8.7.x-dev

Drupal 8.6.0-alpha1 will be released the week of July 16, 2018, which means new developments and disruptive changes should now be targeted against the 8.7.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.7.x-dev » 8.8.x-dev

Drupal 8.7.0-alpha1 will be released the week of March 11, 2019, which means new developments and disruptive changes should now be targeted against the 8.8.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

sean_e_dietrich’s picture

sean_e_dietrich
he/him
Primary language English
Location Sacramento, CA
commented
Status: Needs review » Reviewed & tested by the community
StatusFileSize
new Screen Shot 2019-06-13 at 11.39.31 AM.png269.97 KB
new Screen Shot 2019-06-13 at 11.39.49 AM.png70.09 KB
new Screen Shot 2019-06-13 at 1.27.33 PM.png90.6 KB

Tested patch as I was having a similar issue with a module.

Applied patch successfully.

Codebase currently

Before patching there were some issues

After applying the patch this was successful.

pancho’s picture

pancho
Location UTC+2 🇪🇺 EU
commented

@grathbone wrote:

Also, looks like this could be solved globally, so may want to watch this ticket.
https://www.drupal.org/project/drupal/issues/2190333

#2190333-11: Make #group FAPI / render feature work on all form/render #types out of the box has a working patch now and solves the issue generically. Please test with your usecases.

larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
commented
Status: Reviewed & tested by the community » Needs work

We need some tests here.

But I think it might be best to close as a duplicate of #2190333: Make #group FAPI / render feature work on all form/render #types out of the box

Version: 8.8.x-dev » 8.9.x-dev

Drupal 8.8.0-alpha1 will be released the week of October 14th, 2019, which means new developments and disruptive changes should now be targeted against the 8.9.x-dev branch. (Any changes to 8.9.x will also be committed to 9.0.x in preparation for Drupal 9’s release, but some changes like significant feature additions will be deferred to 9.1.x.). For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

lowfidelity’s picture

lowfidelity
Primary language German
Location Vienna, Austria
commented

Thanks a lot for your patch which seems to work on 8.7.8.

Tho I applied the one at https://www.drupal.org/project/drupal/issues/2190333 which fixed the problem.

Version: 8.9.x-dev » 9.1.x-dev

Drupal 8.9.0-beta1 was released on March 20, 2020. 8.9.x is the final, long-term support (LTS) minor release of Drupal 8, which means new developments and disruptive changes should now be targeted against the 9.1.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 9.1.x-dev » 9.2.x-dev

Drupal 9.1.0-alpha1 will be released the week of October 19, 2020, which means new developments and disruptive changes should now be targeted for the 9.2.x-dev branch. For more information see the Drupal 9 minor version schedule and the Allowed changes during the Drupal 9 release cycle.

pasqualle’s picture

pasqualle
Location 🇭🇺 Budapest
commented
Status: Needs work » Closed (duplicate)

#2190333: Make #group FAPI / render feature work on all form/render #types out of the box should fix this issue