Once https://github.com/commerceguys/addressing/issues/63 lands a new commerceguys/addressing release is made, we'll be able to remove the commerceguys/intl dependency from this module. Opening this issue to track that.

CommentFileSizeAuthor
#4 2853976-4.patch8.93 KBbojanz

Comments

bojanz created an issue. See original summary.

dww’s picture

dww
we/he/they
commented

Cool. I hope https://github.com/commerceguys/addressing/pull/76 also lands before the next commerceguys/addressing release. :)

Thanks,
-Derek

bojanz’s picture

bojanz commented
Title: Remove commerceguys/intl dependency » Update for commerceguys/addressing v1.0

The PR has landed and addressing is ready for a v1.0.
I need to prepare a patch for Address, then tag both the module and the library at the same time.

bojanz’s picture

bojanz commented
Status: Active » Needs review
StatusFileSize
new 2853976-4.patch8.93 KB

I have to switch the library requirement to dev-master temporarily.

Let's see if DrupalCI can handle a requirements change.

EDIT:

Loading composer repositories with package information
Installing dependencies (including require-dev) from lock file
Your requirements could not be resolved to an installable set of packages.

  Problem 1
    - doctrine/collections v1.5.0 requires php ^7.1 -> your PHP version (5.5.38) does not satisfy that requirement.
    - doctrine/collections v1.5.0 requires php ^7.1 -> your PHP version (5.5.38) does not satisfy that requirement.
    - Installation request for doctrine/collections v1.5.0 -> satisfiable by doctrine/collections[v1.5.0].

This is an odd error. Locally when I set the platform PHP to 5.5 I get doctrine/collections v1.3 as expected.
Furthermore, drupal/core already ships with doctrine/collections, so Composer shouldn't be trying to install one at all.

Status: Needs review » Needs work

The last submitted patch, 4: 2853976-4.patch, failed testing. View results

Mixologic’s picture

Mixologic
He/Him/His
Primary language English
Location Portland, OR
commented

Let's see if DrupalCI can handle a requirements change.

It can now properly handle the edge case where when we remove a project, that depends on a library, that happens to have the same dependency as drupal core, that it will no longer update that dependency to the very latest version as part of the removal, which happens on the php7 host environment, breaking the eventual test that runs on php 5.5

  • bojanz committed 9f864b1 on 8.x-1.x 
    Issue #2853976 by bojanz: Update for commerceguys/addressing v1.0
bojanz’s picture

bojanz commented
Status: Needs work » Fixed

Thank you Mixologic, for the build fixes!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.