port the install file configurations.

CommentFileSizeAuthor
#3 noscript_tag.install.zip372 bytessneha_surve

Comments

kunal.kursija created an issue. See original summary.

sneha_surve’s picture

sneha_surve commented
Assigned: Unassigned » sneha_surve
sneha_surve’s picture

sneha_surve commented
Assigned: sneha_surve » Unassigned
Status: Active » Needs review
StatusFileSize
new noscript_tag.install.zip372 bytes

Added install file.

ashishdalvi’s picture

ashishdalvi
Primary language English
Location Mumbai
commented

Hi @polaki_viswanath,

Please create a 8.x-1.x branch. So above changes can be added as a part of patch.

Thanks,
Ashish

polaki_viswanath’s picture

polaki_viswanath commented

Hi Ashish Dalvi

Greetings of the day. How are you.

Do you want me to create a new 8.x branch by using your patches. Have you tested all the patches combined.

I would love to use your patches.

Thanks for the effort.

kunalkursija’s picture

kunalkursija commented
Assigned: Unassigned » kunalkursija
Status: Needs review » Needs work

Hi @polaki_viswanath,

Please create the 8.x branch for this, I am working on this to create a complete updated D8 port.

@sneha_surve Thank you very much for your work. I am making minor Changes in the file, And will share the patch once i have 8.x branch created by @polaki_viswanath.

Also, changing the status to needs work due to missing branch.

Thanks.

ashishdalvi’s picture

ashishdalvi
Primary language English
Location Mumbai
commented

Hi @polaki_viswanath,

Thanks for prompt reply.

I am doing good. How are you?

@kunal.kursija is working towards porting module to D8. @kunal.kursija have completed with most of the features.

Thanks,

polaki_viswanath’s picture

polaki_viswanath commented

Added the 8.x-1.x branch.

kunalkursija’s picture

kunalkursija commented

Thank you @polaki_viswanath for the branch.

It is still under some active development.

After reviewing from my end, I Will start adding patches.

Thanks.

kunalkursija’s picture

kunalkursija commented
Assigned: kunalkursija » Unassigned
Status: Needs work » Needs review

@sneha_surve :

Just to update you that this install file will not be required any more, Because Drupal automatically deletes the configurations from 'config' table when we uninstall the module.

@polaki_viswanath : you have created a 8.x branch, However the issue queue's version filter will not show '8.x-1.x' because this branch is not associated with any module release.
So if possible you should create a development release associated with 8.x branch. That way you can version the D8 port Issues to 8.x-1.x.

polaki_viswanath’s picture

polaki_viswanath commented

Created dev release for 8.x branch of this module.

kunalkursija’s picture

kunalkursija commented
Version: 7.x-1.0 » 8.x-1.x-dev

Thanks viswanath.

polaki_viswanath’s picture

polaki_viswanath commented
Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.