Problem/Motivation

Unlike what the weight indicates we currently don't sort the resulting metatag properties. This can totally result into issues for example with facebook opengraph.

Proposed resolution

Add some sorting.

Remaining tasks

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#5 2853252-5.patch2.58 KBdawehner
#3 2853252-3.patch1.71 KBdawehner
#2 2853252-2.patch890 bytesdawehner
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

dawehner created an issue. See original summary.

dawehner’s picture

dawehner
Primary language German
CreditAttribution: dawehner at Chapter Three commented
Status: Active » Needs review
FileSize
2853252-2.patch890 bytes

There we go.

dawehner’s picture

dawehner
Primary language German
CreditAttribution: dawehner at Chapter Three commented
FileSize
2853252-3.patch1.71 KB

And a test as well.

Status: Needs review » Needs work

The last submitted patch, 3: 2853252-3.patch, failed testing.

dawehner’s picture

dawehner
Primary language German
CreditAttribution: dawehner at Chapter Three commented
Status: Needs work » Needs review
FileSize
2853252-5.patch2.58 KB

And this time combined

DamienMcKenna’s picture

DamienMcKenna
Location NH, USA
CreditAttribution: DamienMcKenna at Mediacurrent commented
Parent issue: » #2563615: Plan for Metatag 8.x-1.1 release

Oh sweet, thanks! I'll review this tomorrow.

dawehner’s picture

dawehner
Primary language German
CreditAttribution: dawehner at Chapter Three commented
Title: Ensure the metatags are ordered by weight » Ensure the metatags aren't ordered by weight

Let's fix the broken title.

DamienMcKenna’s picture

DamienMcKenna
Location NH, USA
CreditAttribution: DamienMcKenna at Mediacurrent commented
Title: Ensure the metatags aren't ordered by weight » Ensure the metatags are ordered correctly
Status: Needs review » Reviewed & tested by the community

DamienMcKenna’s picture

DamienMcKenna
Location NH, USA
CreditAttribution: DamienMcKenna at Mediacurrent commented

Committed. Thanks!

dawehner’s picture

dawehner
Primary language German
CreditAttribution: dawehner at Chapter Three commented
Status: Reviewed & tested by the community » Fixed

Thank you, this was really quick.

dawehner’s picture

dawehner
Primary language German
CreditAttribution: dawehner at Chapter Three commented

Oh sorry for breaking the issue title.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

Nchase’s picture

Nchase CreditAttribution: Nchase as a volunteer commented

with latest 8.x-1.x-dev there is no sorting in the output. Open Graph mixes with Twitter Cards mixes with standard meta info.