Hi guys.

We added a hook for delete variables on uninstall.

Regards.

CommentFileSizeAuthor
#8 hosting-delete_variables_when-2853150-8.patch1008 bytesrenatog
#2 hosting-delete_variables_when-2853150-2.patch460 bytesrenatog
1.png46.44 KBrenatog

Comments

renatog created an issue. See original summary.

renatog’s picture

renatog commented
Assigned: renatog » Unassigned
Issue summary: View changes
Status: Active » Needs review
StatusFileSize
new hosting-delete_variables_when-2853150-2.patch460 bytes

In attachment the patch with the fix.

Regards and Good work.

helmo’s picture

helmo commented

Thanks, this looks ok in theory.

Do you have a scenario where you want to preserve the hostmaster site while uninstalling the aegir modules?

renatog’s picture

renatog commented

Hi @helmo, how are you?

In all scenarios after uninstalling the project there is no need to keep variables stored in the database.

If is need have this variables is possible disable the project and so the variables will continue in the database.

Thank you very much @helmo.

Good work.

colan’s picture

colan
he/him
Primary language English
Location Toronto 🇨🇦
commented

We should probably remove everything, not just the variables, but I'm not sure if the other modules clean up after themselves.

helmo’s picture

helmo commented
Status: Needs review » Needs work

Using the pattern hosting_% is still 'risky' though ... as it would also remove options from other modules like hosting_git (it depends on hosting ... but still )

renatog’s picture

renatog commented
Assigned: Unassigned » renatog

Hi guys.

You are right @helmo.

I will fix it.

renatog’s picture

renatog commented
Assigned: renatog » Unassigned
Status: Needs work » Needs review
StatusFileSize
new hosting-delete_variables_when-2853150-8.patch1008 bytes

Hi @helmo.

Thank you very much for your review.

In attachment new patch.

Regards.

  • helmo committed d1c6b9a on 7.x-3.x authored by renatog 
    Issue #2853150 by renatog: Delete variables when uninstall
helmo’s picture

helmo commented
Status: Needs review » Fixed

thanks. committed.

renatog’s picture

renatog commented

Thank you very much @helmo.

Hugs.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.