Clean up variables on module uninstall [#2851888]

Comment	File	Size	Author
#8	clean_up_variables_on-2851888-8.patch	763 bytes	jaykandari

Comment #1

12 February 2017 at 18:53

vishwac9 created an issue. See original summary.

Log in or register to post comments

Comment #3

vishwac9 commented 12 February 2017 at 19:05

Parent issue:

» #2851891: Incorrect filename

Inorder to fix this issue there is another issue regarding the .install file name which needs to be fixed first. Incorrect file name

Log in or register to post comments

Comment #4

dishabhadra commented 13 February 2017 at 06:37

Hi Vishwa,

For above issue you have mention Proposed solutions, So according to me this is not as per drupal Standards.

In db_delete you have mention condition('name' , 'indeed_%' , 'like') so there is risk in this condition, if we have any other module whose name is similiar to indeed and they have simillar kind of variable then as per this query they will also deleted.

So we can use variable_del($name) function and delete the variable.

Else we should rename the Variable name to 'modulename_country'. Eg. 'indeed_search_country' instead of 'indeed_country'.

Log in or register to post comments

Comment #5

vishwac9 commented 13 February 2017 at 06:46

hi dishabhadra you have a point, just thought instead of writing 7 variable delete which would again involve 7 different queries to the database to delete the variables lets do it in one single query.

Log in or register to post comments

Comment #6

swarad07

English

Navi Mumbai, India

commented 14 February 2017 at 03:49

@Disha is correct, the correct way to do it would be via variable_del(). The API does more than just a delete query.

function variable_del($name) {
  global $conf;

  db_delete('variable')
    ->condition('name', $name)
    ->execute();
  cache_clear_all('variables', 'cache_bootstrap');

  unset($conf[$name]);
}