Wrong usage of file_prepare_directory in hook_install documentation

But what is to be done with $mode then? Where will it be used?
$mode = isset($GLOBALS['install_state']['mode']) ? $GLOBALS['install_state']['mode'] : NULL;

Sorry wrong patch, i'm redoing it!

Bumping the version

Thanks for the patch , it is working fine

+++ b/core/lib/Drupal/Core/Extension/module.api.php
@@ -231,7 +231,7 @@ function hook_install() {
   $mode = isset($GLOBALS['install_state']['mode']) ? $GLOBALS['install_state']['mode'] : NULL;

This now looks weird. In fact this was removed in #2121849: Move file_chmod_directory and file_chmod_file out of config and into settings so that drush_chmod() is independant of the config system and should be cleaned-up here.

When fixing thing like this is it really important to try and work out why things like this occur. Using git log -S is a great way to. It allows to find when lines of code are added and removed. So doing git log -S "file_prepare_directory(\$directory, FILE_CREATE_DIRECTORY | FILE_MODIFY_PERMISSIONS, \$mode);" finds commits related to this issue.

We will work on it in Drupal Mumbai Code sprint #16

I am working on it

Adding a patch.Kindly review it.

There is no $mode param so yeah this looks good.

Thanks all, committed!