Problem/Motivation
Quora have just been ported to D8 and in dev state. After reviewing the code, I found that we need to clean up code on 8.x branch to be more closer to Drupal 8. Readme.txt leads no where how to create API IDs and CX.
Proposed resolution
- Use Dependency Injection.
- Move data manipulation functions as Services
- Use calss FromBase for building forms.
- Clean quora.module file.
- Proper explanations in Read me file.
- Add link configuration settings in UI.
File different issues for each file and add as child issues.
Remaining tasks
- use Dependency Injection in classes instead of
\Drupal. - Adjust String translation functions.
- Use CMI best practices.
- Use actual fields instead of psuedo fields from content type to be displayed as options on configuration settings.
- Move helper functions as services methods.
- Better field descriptions.
- Update READEME.txt.
- Correct config key in info.yml.
- Add parent in links.menu.yml.
Comments
Comment #2
navneet0693 commentedComment #3
navneet0693 commentedComment #4
navneet0693 commentedPlease review child issues :)
Comment #5
navneet0693 commentedComment #6
gg24 commentedThanks for the patches @navneet0693!!