Closed (fixed)
Project:
Webform Views Integration
Version:
8.x-5.x-dev
Component:
Code
Priority:
Normal
Category:
Feature request
Assigned:
Unassigned
Reporter:
Created:
7 Feb 2017 at 22:15 UTC
Updated:
19 Feb 2018 at 15:39 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
bucefal91 commentedGotcha :) When I a chance I'll code this part.
Comment #3
arosboro commentedI just made a patch which addresses this issue.
Comment #4
arosboro commentedComment #5
CatherineOmega commentedThe patch applies cleanly, but I'm not sure I see how to actually add a subfield of a given composite field. Can anyone else confirm?
Comment #6
simohell commentedThanks for this! The patch works well for the version: Commit 5d2b725 on 8.x-5.x
but it seems it won't install with the latest version: Commit a67d79d on 8.x-5.x
update: Seems to work on a clean site even also current dev-version. So the problem at the development site was something else...
However with the clean install for some reason don't seem to be getting any output from default Address-elements City and Postal code output, although I can see the sub-elements data in the views field with complete element.
Comment #7
bucefal91 commentedNice patch in #3 - thank you. It leverages a really nice idea of exposing each composite as a separate table, so the actual views handlers (field/sort/filter) do not have to worry about proper filtering out other components out.
I have reviewed it and taken slightly further the work. Namely:
On the address field, I've tried the following test cases:
No issues were identified. Feedback about the patch is very welcome. As far as I am concerned this patch is commit ready.
Comment #9
bucefal91 commentedI have committed my patch #7.
Thank you once again for your contribution :)