Target set to UNTRACKED

+++ b/src/Tests/LingotekNodeTranslationFlowNotCurrentToPendingTest.php
@@ -0,0 +1,139 @@
+class LingotekNodeTranslationFlowNotCurrentToPendingTest extends LingotekTestBase {
...
+  public function testNodeTargetStatusAfterSourceEditAndUpload() {

Didn't look at this in detail yet, but at least we need more tests for config and config entities.

Removed the ToDo and changed tests as now #2850545: Check All Translation Progress Action not updating status correctly has been committed.

1. +++ b/src/LingotekConfigTranslationService.php
   @@ -258,15 +258,27 @@ class LingotekConfigTranslationService implements LingotekConfigTranslationServi
   -        if ($current_status === Lingotek::STATUS_PENDING && $status === Lingotek::STATUS_REQUEST) {
   +        if ($current_status === Lingotek::STATUS_PENDING &&
   +        $status === Lingotek::STATUS_REQUEST) {
   

   This change mades readability worse IMHO.

2. +++ b/src/LingotekConfigTranslationService.php
   @@ -258,15 +258,27 @@ class LingotekConfigTranslationService implements LingotekConfigTranslationServi
   +        if (in_array( $current_status,
   +                      array(  Lingotek::STATUS_UNTRACKED,
   +                              Lingotek::STATUS_DISABLED
   +                      )) &&
   +        $status === Lingotek::STATUS_PENDING) {
   

   Same here, a single line if using short array syntax should be better.

3. +++ b/src/LingotekConfigTranslationService.php
   @@ -258,15 +258,27 @@ class LingotekConfigTranslationService implements LingotekConfigTranslationServi
   +        elseif ($current_status == Lingotek::STATUS_EDITED && in_array($status,
   +        array(Lingotek::STATUS_CURRENT, Lingotek::STATUS_PENDING))) {
   

   Short array syntax here too.

4. +++ b/src/Tests/LingotekConfigEntityTranslationEditedToPendingTest.php
   @@ -0,0 +1,116 @@
   +    // TODO: once the config is following the correct translation flow then the
   +    // following tests will work, but for now it's not
   

   What's wrong here then? Do we have an issue?

5. +++ b/src/Tests/LingotekConfigTranslationEditedToPendingTest.php
   @@ -0,0 +1,133 @@
   +    // Set Site name back to original name
   +    $config2->set('name', $original_site_name)->save();
   

   Why is this needed?

This looks better, thanks! I will fix a couple of coding standards issues at commit (extra spaces on in_array and short syntax arrays)

Interdiff before commit.

Committed 6ec333e and pushed to 8.x-1.x. Thanks!

Committed fa5906e and pushed to 8.x-2.x. Thanks!

If our tests didn't detect that we definitely need tests. If this patch failed, is there a problem with requirement or a big in our tests?

Committed 9039a4b and pushed to 8.x-1.x. Thanks!
Committed 3d3a26e and pushed to 8.x-2.x. Thanks!