target-edited (NOT_CURRENT) is styled identical to target-current (CURRENT) which is odd since they are exact opposites but visually are represented the same. But according to the Lingotek Connector Requirements document it should be styled with a border and font color #2196F3 and a background color of #FFFFFF

CommentFileSizeAuthor
#6 Screen Shot 2017-02-24 at 22.46.21.png41.94 KBpenyaskito
#2 target_edited_styled-2850521-2.patch886 bytest.murphy

Comments

t.murphy created an issue. See original summary.

t.murphy’s picture

t.murphy commented
Status: Active » Needs review
StatusFileSize
new target_edited_styled-2850521-2.patch886 bytes
t.murphy’s picture

t.murphy commented
Status: Needs review » Fixed
t.murphy’s picture

t.murphy commented
Status: Fixed » Reviewed & tested by the community
t.murphy’s picture

t.murphy commented
Status: Reviewed & tested by the community » Needs review
penyaskito’s picture

penyaskito
he/him
Primary language Spanish
Location 🧑🏽‍🌾 Seville 💃 Andalusia, UTC+2 🇪🇺
commented
Status: Needs review » Reviewed & tested by the community
StatusFileSize
new Screen Shot 2017-02-24 at 22.46.21.png41.94 KB

Screenshot before and after:

penyaskito’s picture

penyaskito
he/him
Primary language Spanish
Location 🧑🏽‍🌾 Seville 💃 Andalusia, UTC+2 🇪🇺
commented 
+++ b/css/base.css
@@ -128,18 +128,27 @@ a.language-icon {
+  background-color:#FFC107;
...
+    background-color: #FFB300;

https://www.drupal.org/docs/develop/standards/css/css-formatting-guideli... says that hex color should be lowercased. Doing that on commit.

diff --git a/css/base.css b/css/base.css
index b12cc85..b48b509 100644
--- a/css/base.css
+++ b/css/base.css
@@ -129,7 +129,7 @@ a.language-icon {
   }

 .language-icon.target-edited {
-  background-color:#FFC107;
+  background-color:#ffc107;
   border: 1px solid #575757;
   color: #575757;
 }
@@ -137,7 +137,7 @@ a.language-icon {
     color: #575757;
   }
   .language-icon.target-edited:hover {
-    background-color: #FFB300;
+    background-color: #ffb300;
   }

 .language-icon.target-current {

  • penyaskito committed f880567 on 8.x-1.x authored by t.murphy 
    Issue #2850521 by t.murphy, penyaskito: target-edited styled identical...
penyaskito’s picture

penyaskito
he/him
Primary language Spanish
Location 🧑🏽‍🌾 Seville 💃 Andalusia, UTC+2 🇪🇺
commented
Status: Reviewed & tested by the community » Fixed

Committed f880567 and pushed to 8.x-1.x. Thanks!

  • penyaskito committed f880567 on 8.x-2.x authored by t.murphy 
    Issue #2850521 by t.murphy, penyaskito: target-edited styled identical...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.