Closed (fixed)
Project:
Easy Breadcrumb
Version:
8.x-1.x-dev
Component:
Code
Priority:
Normal
Category:
Bug report
Assigned:
Reporter:
Created:
4 Feb 2017 at 13:31 UTC
Updated:
20 Feb 2017 at 17:14 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
laue commentedComment #3
laue commentedComment #4
greg boggsWow, nice Laue, thanks!
In truth, I've never used that checkbox. It was left over from D7. Now that I think about it, do you really want a link to the current page that refreshes the page when clicked?
Comment #5
laue commentedI'm working on a custom theme and it looks better if that breadcrumb is a link. I checked it and when I saw it does nothing, I wanted to understand why. I'm already using the patch in my project, so I thought I could share it.
Nice module by the way.
Comment #6
greg boggsHi Laue,
Your patch does not apply. Can you reroll it? This may help: https://www.drupal.org/node/707484
patch -p1 < easy_breadcrumb-title_link-2849717-1.patch
can't find file to patch at input line 5
Perhaps you used the wrong -p or --strip option?
The text leading up to this was:
--------------------------
|<+>UTF-8
|===================================================================
|--- docroot/modules/contrib/easy_breadcrumb/src/EasyBreadcrumbBuilder.php (date 1486214709000)
|+++ docroot/modules/contrib/easy_breadcrumb/src/EasyBreadcrumbBuilder.php (revision )
--------------------------
File to patch: ^C
Comment #7
greg boggsComment #8
laue commentedHey Greg,
First time attempting to make a patch and I thought I can get away by making it via the IDE. Our build also failed because of it :D. Now I made a patch using git diff and I'm hoping this time it will apply.
Comment #9
laue commentedOkay, so patches have to be made from the root of the module, not the root of the project. Makes sense. This should work.
Comment #11
greg boggsYou got it, I pushed your patch with a little bit of respacing since the line got really long. Thanks for your contribution!
Comment #12
greg boggs