Wrong information in the documentation in _default-variables.scss [#2849618]

Hello.

In the file _default-variables.scss, the following code refers to the path

./THEMENAME/bootstrap/assets/stylesheets/_variables.scss

But that path does not exist. It should be

./THEMENAME/bootstrap/assets/stylesheets/bootstrap/_variables.scss

/**
 * Default Variables.
 *
 * Modify this file to provide default Bootstrap Framework variables. The
 * Bootstrap Framework will not override any variables defined here because it
 * uses the `!default` flag which will only set their default if not already
 * defined here.
 *
 * You can copy existing variables directly from the following file:
 * ./THEMENAME/bootstrap/assets/stylesheets/_variables.scss
 */

// Set the proper directory for the Bootstrap Glyphicon font.
$icon-font-path: '../bootstrap/assets/fonts/bootstrap/';

Comment	File	Size	Author
#4	bootstrap-wrong_filepath-2849618-4.patch	414 bytes	renat
#4

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

3 February 2017 at 20:56

asiby created an issue. See original summary.

Comment #2

asiby CreditAttribution: asiby commented 3 February 2017 at 20:57

Title:	Misinformation is the documentation in _default-variables.scss	» Wrong information in the documentation in _default-variables.scss
Issue summary:	View changes

Comment #3

asiby CreditAttribution: asiby commented 3 February 2017 at 20:57

Issue summary:

View changes

Comment #4

renat CreditAttribution: renat as a volunteer commented 20 February 2017 at 05:16

Version:	7.x-3.10	» 8.x-3.x-dev
Status:	Active	» Needs review

File	Size
bootstrap-wrong_filepath-2849618-4.patch	414 bytes

Confirm, asiby is absolutely correct. Here is the patch, so we'll be able to see it fixed sooner.

Comment #5

renat CreditAttribution: renat as a volunteer commented 20 February 2017 at 05:17

Version:

8.x-3.x-dev

» 7.x-3.x-dev

Comment #6

Aanal.addweb CreditAttribution: Aanal.addweb at AddWeb Solution Pvt. Ltd. commented 20 February 2017 at 06:23

Status:

Needs review

» Reviewed & tested by the community

@renat, Thank you for the patch, it works well.

Comment #7

21 February 2017 at 00:52

markcarver committed 3cc01ec on 8.x-3.x authored by renat

Issue #2849618 by renat, asiby: Wrong information in the documentation...

Comment #8

21 February 2017 at 00:53

markcarver committed ad2e1ed on 7.x-3.x authored by renat

Issue #2849618 by renat, asiby: Wrong information in the documentation...

Comment #9

markhalliwell

English

CreditAttribution: markhalliwell at Tag1 Consulting commented 21 February 2017 at 00:54

Status:

Reviewed & tested by the community

» Fixed

Ran into #2854361: Source files in SASS starterkit are underneath "sass" folder instead of "scss" when attempting to apply patch to 8.x-3.x, but fixed on both. Thanks!

Comment #10

Aanal.addweb CreditAttribution: Aanal.addweb at AddWeb Solution Pvt. Ltd. commented 23 February 2017 at 09:57

@markcarver I guess, you forgot providing me a credit for RTBC I performed. Can you please do the needful..?

Comment #11

markhalliwell

English

CreditAttribution: markhalliwell at Tag1 Consulting commented 23 February 2017 at 17:17

Comment #12

asiby CreditAttribution: asiby commented 23 February 2017 at 17:54

I do not understand that credit attribution thingy. It has Author and By. What is what in this case? Because I reported this issue, but I see that it says that author is @renat. I personally don't mind as long as things are being solved. It's just that I have my module modules to maintain and I would like to be doing the correct thing there too. :)

Comment #13

markhalliwell

English

CreditAttribution: markhalliwell at Tag1 Consulting commented 23 February 2017 at 18:15

So, yes, the whole "credit" topic is rather confusing at first. It partially due to the evolution of what we have considered as "credit" over the years.

There are actually 3 distinct areas/concepts/history of "credit" in our community, I'll try to help summarize with short descriptions/links:

First came: CSV/Git Commit Messages

This is the Issue #[issue number] by [comma-separated usernames]: [Short summary of the change] commit messages. It's how we track who reported the issue and all the individuals who helped on the issue.

Second came: Git --author flag

This is the individual who actually created said patch that was committed. This is what is displayed in the above system messages #7 and #8: "authored by"

Third came: Drupal.org's Issue/Commit Credit UI

This UI was heavily inspired by the original Dreditor browser extension commit credit plugin. It is now, however, a full d.o feature that stores each issue's "commit credit" values directly in d.o database. This allows for things like the "Credited on X issues fixed in the past 1 year" section on user's profiles.
It does not, however, have any real direct ties to project repository commit messages anymore and is the only real way to retroactively credit someone. My blank comment in #11 was actually me giving @dhwani.addweb "credit" (see her profile now) for this issue. Of course, since this was a retroactive credit as she isn't actually mentioned in the repository's commit history (sorry!).

Comment #14

asiby CreditAttribution: asiby commented 23 February 2017 at 18:54

Wow. Thank you so much for these clarifications @markcarver. It confirms that not matter how much we know, what we still don't know can fill the ever expanding universe. hahahaha.

Plus, I have never noticed the "Credited on X issues fixed in the past 1 year" in the past. Maybe because I was even though I have reported bugs and tried contributing in various ways to solve some of them.

I will keep that in mind to ensure that everyone will be properly credited for what they do in the future. ;)

Thanks again.