Hello.
In the file _default-variables.scss, the following code refers to the path
./THEMENAME/bootstrap/assets/stylesheets/_variables.scss
But that path does not exist. It should be
./THEMENAME/bootstrap/assets/stylesheets/bootstrap/_variables.scss
/**
* Default Variables.
*
* Modify this file to provide default Bootstrap Framework variables. The
* Bootstrap Framework will not override any variables defined here because it
* uses the `!default` flag which will only set their default if not already
* defined here.
*
* You can copy existing variables directly from the following file:
* ./THEMENAME/bootstrap/assets/stylesheets/_variables.scss
*/
// Set the proper directory for the Bootstrap Glyphicon font.
$icon-font-path: '../bootstrap/assets/fonts/bootstrap/';
| Comment | File | Size | Author |
|---|---|---|---|
| #4 | bootstrap-wrong_filepath-2849618-4.patch | 414 bytes | renat |
Comments
Comment #2
asiby commentedComment #3
asiby commentedComment #4
renat commentedConfirm, asiby is absolutely correct. Here is the patch, so we'll be able to see it fixed sooner.
Comment #5
renat commentedComment #6
Aanal.addweb commented@renat, Thank you for the patch, it works well.
Comment #9
markhalliwellRan into #2854361: Source files in SASS starterkit are underneath "sass" folder instead of "scss" when attempting to apply patch to 8.x-3.x, but fixed on both. Thanks!
Comment #10
Aanal.addweb commented@markcarver I guess, you forgot providing me a credit for RTBC I performed. Can you please do the needful..?
Comment #11
markhalliwellComment #12
asiby commentedI do not understand that credit attribution thingy. It has Author and By. What is what in this case? Because I reported this issue, but I see that it says that author is @renat. I personally don't mind as long as things are being solved. It's just that I have my module modules to maintain and I would like to be doing the correct thing there too. :)
Comment #13
markhalliwellSo, yes, the whole "credit" topic is rather confusing at first. It partially due to the evolution of what we have considered as "credit" over the years.
There are actually 3 distinct areas/concepts/history of "credit" in our community, I'll try to help summarize with short descriptions/links:
First came: CSV/Git Commit Messages
Issue #[issue number] by [comma-separated usernames]: [Short summary of the change]commit messages. It's how we track who reported the issue and all the individuals who helped on the issue.Second came: Git
--authorflagThird came: Drupal.org's Issue/Commit Credit UI
It does not, however, have any real direct ties to project repository commit messages anymore and is the only real way to retroactively credit someone. My blank comment in #11 was actually me giving @dhwani.addweb "credit" (see her profile now) for this issue. Of course, since this was a retroactive credit as she isn't actually mentioned in the repository's commit history (sorry!).
Comment #14
asiby commentedWow. Thank you so much for these clarifications @markcarver. It confirms that not matter how much we know, what we still don't know can fill the ever expanding universe. hahahaha.
Plus, I have never noticed the "Credited on X issues fixed in the past 1 year" in the past. Maybe because I was even though I have reported bugs and tried contributing in various ways to solve some of them.
I will keep that in mind to ensure that everyone will be properly credited for what they do in the future. ;)
Thanks again.
Comment #15
markhalliwellNp :D