Comments

WidgetsBurritos created an issue. See original summary.

WidgetsBurritos’s picture

Assigned: Unassigned » pobster
Status: Active » Needs review
StatusFileSize
new4.75 KB

This patch adds support for the panelizer_entity container.

WidgetsBurritos’s picture

For reference:

Before:
Before

After:
After

Status: Needs review » Needs work

The last submitted patch, 2: panels-pane-report-support-panelizer-2849614-2.patch, failed testing.

WidgetsBurritos’s picture

Assigned: pobster » Unassigned
Status: Needs work » Needs review
StatusFileSize
new64 bytes
new2.48 KB

Thank goodness for test coverage. Let's try that again...

WidgetsBurritos’s picture

Well let's try that again...

The last submitted patch, 2: panels-pane-report-support-panelizer-2849614-2.patch, failed testing.

The last submitted patch, 5: panels-pane-report-support-panelizer-2849614-3.patch, failed testing.

WidgetsBurritos’s picture

StatusFileSize
new6.4 KB

And one more with an updated test.

WidgetsBurritos’s picture

Status: Needs review » Needs work

Now that we have better test coverage, this should get covered by that.

WidgetsBurritos’s picture

Status: Needs work » Needs review
StatusFileSize
new3.44 KB

This is the test only. This should fail.

WidgetsBurritos’s picture

StatusFileSize
new9.58 KB

This is the test and the patch. This should pass.

The last submitted patch, 11: add_better_support_for-2849614-11-test-only.patch, failed testing.

Status: Needs review » Needs work

The last submitted patch, 12: add_better_support_for-2849614-12.patch, failed testing.

WidgetsBurritos’s picture

WidgetsBurritos’s picture

StatusFileSize
new3.1 KB

Whoops. Let's try this again.

WidgetsBurritos’s picture

Status: Needs work » Needs review

Status: Needs review » Needs work

The last submitted patch, 16: add_better_support_for-2849614-16-test-only.patch, failed testing.

WidgetsBurritos’s picture

Issue summary: View changes
StatusFileSize
new3.09 KB
WidgetsBurritos’s picture

Status: Needs work » Needs review

Status: Needs review » Needs work

The last submitted patch, 19: test-only-2849614-19.patch, failed testing.

WidgetsBurritos’s picture

Status: Needs work » Needs review
StatusFileSize
new0 bytes

Still having issues. Trying to see if it's a CI issue, or an issue with my patch.

Status: Needs review » Needs work

The last submitted patch, 22: empty.patch, failed testing.

WidgetsBurritos’s picture

Issue summary: View changes
Status: Needs work » Needs review
StatusFileSize
new3.2 KB

Trying a slight modification to the setup() function to see if it can resolve properly.

Status: Needs review » Needs work

The last submitted patch, 24: test-only-2849614-24.patch, failed testing.

WidgetsBurritos’s picture

So I'm guessing the reason this keeps failing to run is due to panelizer being an external module, instead of a submodule of panels. Since panelizer was never specified as a dependency in the .info file (mainly as I wanted to keep this optional), I don't believe it's actually downloading the code. I'll test this theory later, but jotting it down now in case anyone stumbles across this thread.

WidgetsBurritos’s picture

Status: Needs work » Needs review
StatusFileSize
new3.86 KB

Just uploading this to test if adding the dependency fixes the test issue. I don't necessarily want to add this module dependency, but I just want to confirm if it solves the bug in the CI environment.

WidgetsBurritos’s picture

StatusFileSize
new3.86 KB

Not sure why it didn't queue for testing. Trying again.

Status: Needs review » Needs work

The last submitted patch, 28: test-only-2849614-27.patch, failed testing.

WidgetsBurritos’s picture

Status: Needs work » Needs review
StatusFileSize
new3.57 KB

Just saw the note about `test_dependencies[]` in the info file. Giving that a shot.

Status: Needs review » Needs work

The last submitted patch, 30: test-only-2849614-30.patch, failed testing.

WidgetsBurritos’s picture

StatusFileSize
new3.71 KB

Attempting to use `package:module` declarations in info file

WidgetsBurritos’s picture

Status: Needs work » Needs review

Status: Needs review » Needs work

The last submitted patch, 32: test-only-2849614-32.patch, failed testing.

WidgetsBurritos’s picture

Title: Add better support for 'panelizer_entity' container » Add better support for panelizer_entity container
WidgetsBurritos’s picture

Status: Needs work » Needs review
StatusFileSize
new3.1 KB

Status: Needs review » Needs work

The last submitted patch, 36: add_better_support_for-2849614-36.patch, failed testing.

WidgetsBurritos’s picture

Now that the test issue has been resolved, I'm gonna focus on rewriting the tests in the same manner I'm looking to rewrite the other tests so, still needs work.

WidgetsBurritos’s picture

Status: Needs work » Needs review
StatusFileSize
new3.18 KB
new9.58 KB

The last submitted patch, 39: test-only-2849614-39.patch, failed testing.

WidgetsBurritos’s picture

Assigned: Unassigned » bighappyface
bighappyface’s picture

Assigned: bighappyface » WidgetsBurritos
Status: Needs review » Reviewed & tested by the community

+1

  • WidgetsBurritos committed 048b32a on 7.x-1.x
    Issue #2849614 by WidgetsBurritos, bighappyface: Add better support for...
WidgetsBurritos’s picture

Status: Reviewed & tested by the community » Fixed
WidgetsBurritos’s picture

Status: Fixed » Closed (fixed)

WidgetsBurritos’s picture

Just realized I never attributed credit here for the help. My bad.

WidgetsBurritos’s picture