Closed (fixed)
Project:
Panels Pane Report
Version:
7.x-1.x-dev
Component:
Code
Priority:
Normal
Category:
Feature request
Assigned:
Reporter:
Created:
3 Feb 2017 at 20:36 UTC
Updated:
16 Aug 2017 at 20:58 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
WidgetsBurritos commentedThis patch adds support for the panelizer_entity container.
Comment #3
WidgetsBurritos commentedFor reference:
Before:

After:

Comment #5
WidgetsBurritos commentedThank goodness for test coverage. Let's try that again...
Comment #6
WidgetsBurritos commentedWell let's try that again...
Comment #9
WidgetsBurritos commentedAnd one more with an updated test.
Comment #10
WidgetsBurritos commentedNow that we have better test coverage, this should get covered by that.
Comment #11
WidgetsBurritos commentedThis is the test only. This should fail.
Comment #12
WidgetsBurritos commentedThis is the test and the patch. This should pass.
Comment #15
WidgetsBurritos commentedComment #16
WidgetsBurritos commentedWhoops. Let's try this again.
Comment #17
WidgetsBurritos commentedComment #19
WidgetsBurritos commentedComment #20
WidgetsBurritos commentedComment #22
WidgetsBurritos commentedStill having issues. Trying to see if it's a CI issue, or an issue with my patch.
Comment #24
WidgetsBurritos commentedTrying a slight modification to the setup() function to see if it can resolve properly.
Comment #26
WidgetsBurritos commentedSo I'm guessing the reason this keeps failing to run is due to panelizer being an external module, instead of a submodule of panels. Since panelizer was never specified as a dependency in the .info file (mainly as I wanted to keep this optional), I don't believe it's actually downloading the code. I'll test this theory later, but jotting it down now in case anyone stumbles across this thread.
Comment #27
WidgetsBurritos commentedJust uploading this to test if adding the dependency fixes the test issue. I don't necessarily want to add this module dependency, but I just want to confirm if it solves the bug in the CI environment.
Comment #28
WidgetsBurritos commentedNot sure why it didn't queue for testing. Trying again.
Comment #30
WidgetsBurritos commentedJust saw the note about `test_dependencies[]` in the info file. Giving that a shot.
Comment #32
WidgetsBurritos commentedAttempting to use `package:module` declarations in info file
Comment #33
WidgetsBurritos commentedComment #35
WidgetsBurritos commentedComment #36
WidgetsBurritos commentedComment #38
WidgetsBurritos commentedNow that the test issue has been resolved, I'm gonna focus on rewriting the tests in the same manner I'm looking to rewrite the other tests so, still needs work.
Comment #39
WidgetsBurritos commentedComment #41
WidgetsBurritos commentedComment #42
bighappyface commented+1
Comment #44
WidgetsBurritos commentedComment #45
WidgetsBurritos commentedComment #47
WidgetsBurritos commentedJust realized I never attributed credit here for the help. My bad.
Comment #48
WidgetsBurritos commented