Noticed that t() get's called a lot from date_views_filter_handler_simple::operators()

Suggest maybe we just static cache the results.

CommentFileSizeAuthor
#5 date-n2848963-5.patch989 bytesdamienmckenna
#5 date-n2848963-5.interdiff.txt957 bytesdamienmckenna
#2 XHProf__Hierarchical_Profiler_Report.png221.94 KBjoelpittet
#2 2848963-2.patch936 bytesjoelpittet

Comments

joelpittet created an issue. See original summary.

joelpittet’s picture

joelpittet
he/him
Primary language English
Location Vancouver
commented
Status: Active » Needs review
StatusFileSize
new 2848963-2.patch936 bytes
new XHProf__Hierarchical_Profiler_Report.png221.94 KB

Here's my results:

test

joelpittet’s picture

joelpittet
he/him
Primary language English
Location Vancouver
commented

bump

damienmckenna’s picture

damienmckenna
Location TN, USA
commented

Is it possible that the parent::operators list might change on the same request, that this could cause regressions? Might it be more beneficial to just cache the new array?

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
StatusFileSize
new date-n2848963-5.interdiff.txt957 bytes
new date-n2848963-5.patch989 bytes

Updated per my idea in #4, please let me know what you think.

joelpittet’s picture

joelpittet
he/him
Primary language English
Location Vancouver
commented
Status: Needs review » Reviewed & tested by the community

Good idea, thanks for thinking ahead on that one. The likelihood is slim but in the realm of possibility.

joelpittet’s picture

joelpittet
he/him
Primary language English
Location Vancouver
commented
Status: Reviewed & tested by the community » Needs review

Probably should get someone else to RTBC this since I worked on it.

joelpittet’s picture

joelpittet
he/him
Primary language English
Location Vancouver
commented
Status: Needs review » Reviewed & tested by the community

Back to RTBC

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Status: Reviewed & tested by the community » Fixed
Parent issue: » #2867810: Plan for Date 7.x-2.11 release

Committed.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.