Problem/Motivation

Site builders may allow adding h1 tags in formatted texts. Text of those elements get invisible because of the .adminimal h1 selector eg. if the formatted text is displayed by paragraph preview.

Proposed resolution

Use a weaker and more semantic selector(s): .page-title

CommentFileSizeAuthor
#5 adminimal-page-title-2848335-4.patch324 bytesbandanasharma
#3 update-patch-error.png62.13 KBsakthivel m
#2 adminimal-page_title_selector-2848335-2.patch324 byteshuzooka

Comments

huzooka created an issue. See original summary.

huzooka’s picture

huzooka
Primary language Hungarian
Location Hungary 🇭🇺🇪🇺
commented
Assigned: huzooka » Unassigned
Status: Active » Needs review
StatusFileSize
new adminimal-page_title_selector-2848335-2.patch324 bytes
sakthivel m’s picture

sakthivel m commented
StatusFileSize
new update-patch-error.png62.13 KB

Hi huzooka,
#2 Update patch following error:
Checking patch css/adminimal.css...
error: while searching for:
font: normal 81.3%/1.538em "Open Sans", sans-serif;
}

.adminimal h1,
.adminimal .heading-a {
font-weight: 300;
margin-bottom: 19px;

error: patch failed: css/adminimal.css:33
error: css/adminimal.css: patch does not apply
I have attached screenshot here

bandanasharma’s picture

bandanasharma commented
Status: Needs review » Needs work
bandanasharma’s picture

bandanasharma commented
Status: Needs work » Needs review
StatusFileSize
new adminimal-page-title-2848335-4.patch324 bytes

Re-roll the #2 patch.

andrtroe’s picture

andrtroe commented

Fixed in https://www.drupal.org/project/adminimal_theme/issues/2925553

andrtroe’s picture

andrtroe commented
Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.