Comments

webchick created an issue. See original summary.

xjm’s picture

Title: Update to latest CKEditor version in advance of 8.3.0-rc1 » Update to CKEditor 4.6.2
Version: 8.3.x-dev » 8.2.x-dev
Priority: Major » Normal

Patch updates can be done in patch releases, so no need to do anything special here.

wim leers’s picture

Version: 8.2.x-dev » 8.3.x-dev

4.6 is in 8.3. 8.2 will never get 4.6.2.

boaloysius’s picture

I would like to help in updating.

wim leers’s picture

Issue summary: View changes
Parent issue: » #2828494: Update CKEditor library to 4.6

IS updated.

@boaloysius: you're welcome to do so! There's plenty of examples to look at for updates we did in the past, see the updated IS :)

boaloysius’s picture

Should we add New Color Button palette which is there in CKEditor 4.6.2

wim leers’s picture

#6: No. Just do an update. Adding new CKEditor features must be done in a separate issue. This must do just an update. Nothing more, nothing less. Minimize risk of every change.

wim leers’s picture

Title: Update to CKEditor 4.6.2 » Update CKEditor library to 4.6.2
boaloysius’s picture

StatusFileSize
new2.87 MB

I made a patch. Please check my steps.

  • Downloaded Drupal Core 8.3 dev version and Ckeditor 4.6.2
  • Replaced build-config.js, CHANGES.md, ckeditor.js, lang folder, LICENSE.md
  • Moono skin is retained
  • Replaced plugins with the corresponding in CKEditor4.6.2
  • Retained image2, sourcedialogue and widget plugins
  • showblocks plugin is taken from CKEditor 4.6.2 full package
  • Changed Version and License url in core/core.libraries.yml
wim leers’s picture

Status: Active » Needs work

I'm afraid I see lots of problems. For example, you modified build-config.js.

You shouldn't just download CKEditor 4.6.2. Drupal 8 has a custom build of CKEditor. You need to clone the CKEditor git repository, go into the builder directory and run sh build.sh -s, as is documented in core/assets/vendor/ckeditor/build-config.js. You'll need to use Drupal's own build-config.js, not the default.

boaloysius’s picture

StatusFileSize
new2.3 MB
boaloysius’s picture

boaloysius’s picture

Status: Needs work » Needs review
wim leers’s picture

Status: Needs review » Reviewed & tested by the community

Perfect! Manually tested, still works correctly. Thanks! :)

wim leers’s picture

Also, 4.6.2 added the Azerbaijani language. CKEditor uses the az langcode. Drupal uses the same langcode. So this translation will automatically start working inside Drupal as well! :)

boaloysius’s picture

Yaay!! thanks, Wim Leers

wim leers’s picture

Thank you, @boaloysius :)

webchick’s picture

Adjusting credit.

webchick’s picture

Status: Reviewed & tested by the community » Fixed

Committed and pushed to 8.4.x and cherry-picked to 8.3.x. Thanks a lot!!

webchick’s picture

Issue tags: +8.3.0 release notes

  • webchick committed 6dc023c on 8.4.x
    Issue #2848215 by boaloysius, Wim Leers: Update CKEditor library to 4.6....

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

boaloysius’s picture