Over in #2828494: Update CKEditor library to 4.6 in order to compartmentalize a bit, we only moved to the 4.6.0 release. However, before 8.3.0's release it'd be good to be on the latest (currently 4.6.2).
Update CKEditor to 4.6.2: http://ckeditor.com/blog/CKEditor-4.6.2-released
4.6.1 + 4.6.2 bring:
- new language: Azerbaijani
- Bugfixes
See also:
#1858210: [meta] Content editing experience follow-ups — in-place editing and WYSIWYG
#1950098: Update CKEditor library to 4.1
#2036253: Update CKEditor library to 4.2
#2039163: Update CKEditor library to 4.4
#2271051: Update CKEditor library to 4.4.4
#2345961: Update CKEditor library to 4.4.5
#2384581: Security: Update CKEditor library to 4.4.6
#2415111: Update CKEditor library to 4.4.7
#2521820: Update CKEditor library to 4.5.3
#2321583: Update CKEditor library to 4.5.5
#2663566: Update CKEditor library to 4.5.7
#2698587: Update CKEditor library to 4.5.8
#2724225: Update CKEditor library to 4.5.9
#2765751: Update CKEditor library to 4.5.10
#2797427: Update CKEditor library to 4.5.11
#2828494: Update CKEditor library to 4.6
| Comment | File | Size | Author |
|---|---|---|---|
| #11 | cke_4.6.2-2848215-11.patch | 2.3 MB | boaloysius |
Comments
Comment #2
xjmPatch updates can be done in patch releases, so no need to do anything special here.
Comment #3
wim leers4.6 is in 8.3. 8.2 will never get 4.6.2.
Comment #4
boaloysius commentedI would like to help in updating.
Comment #5
wim leersIS updated.
@boaloysius: you're welcome to do so! There's plenty of examples to look at for updates we did in the past, see the updated IS :)
Comment #6
boaloysius commentedShould we add New Color Button palette which is there in CKEditor 4.6.2
Comment #7
wim leers#6: No. Just do an update. Adding new CKEditor features must be done in a separate issue. This must do just an update. Nothing more, nothing less. Minimize risk of every change.
Comment #8
wim leersComment #9
boaloysius commentedI made a patch. Please check my steps.
Comment #10
wim leersI'm afraid I see lots of problems. For example, you modified
build-config.js.You shouldn't just download CKEditor 4.6.2. Drupal 8 has a custom build of CKEditor. You need to clone the CKEditor git repository, go into the builder directory and run
sh build.sh -s, as is documented incore/assets/vendor/ckeditor/build-config.js. You'll need to use Drupal's ownbuild-config.js, not the default.Comment #11
boaloysius commentedComment #12
boaloysius commentedComment #13
boaloysius commentedComment #14
wim leersPerfect! Manually tested, still works correctly. Thanks! :)
Comment #15
wim leersAlso, 4.6.2 added the Azerbaijani language. CKEditor uses the
azlangcode. Drupal uses the same langcode. So this translation will automatically start working inside Drupal as well! :)Comment #16
boaloysius commentedYaay!! thanks, Wim Leers
Comment #17
wim leersThank you, @boaloysius :)
Comment #18
webchickAdjusting credit.
Comment #19
webchickCommitted and pushed to 8.4.x and cherry-picked to 8.3.x. Thanks a lot!!
Comment #20
webchickComment #23
boaloysius commented