Closed (fixed)
Project:
EU Cookie Compliance (GDPR Compliance)
Version:
8.x-1.0-beta7
Component:
Code
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
30 Jan 2017 at 14:43 UTC
Updated:
8 Mar 2018 at 20:16 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
spurlos commentedComment #3
killua99 commentedComment #4
svenryen commented@killua99 what are the reasons why this issue needs work? Is it in need of a review only or do you notice any issues with the patch?
Comment #5
killua99 commentedI forgot about that, to tell why need work and I won't thing is needed.
Because the patch is a hack, to solve a situation about a thirdparty module. It add just a simple function to create a custom module to alter that variable. It should be handle for that module directly. If that guy will create a custom module to handle IP then why not submit that code on the thirdparty module that we're waiting for?
Comment #6
svenryen commentedI disagree. I think we can add this patch to the module, but I recommend that we name the hook "eu_cookie_compliance_geoip_match"
Comment #7
svenryen commentedComment #8
svenryen commentedI does however need an additional `eu_cookie_compliance.api.php` file to describe the alter hook.
Comment #9
svenryen commentedHere's a complete patch, with the necessary api documentation.
Comment #10
svenryen commentedComment #12
svenryen commentedComment #13
svenryen commented