We need to integrate Token module. This would allow us to provide tokens for data rather static content.

CommentFileSizeAuthor
#11 integrate_token_module-2847556-11.patch3.48 KBjitendra verma
#10 integrate_token_module-2847556-10.patch3.47 KBjitendra verma
#8 integrate_token_module-2847556-8.patch2.41 KBjitendra verma
#7 integrate_token_module-2847556-7.patch2.42 KBjitendra verma
#5 integrate_token_module-2847556-5.patch2.42 KBjitendra verma
#3 integrate_token_module-2847556-3.patch1.68 KBjitendra verma
#2 integrate_token_module-2847556-2.patch1.74 KBjitendra verma

Comments

vaibhavjain created an issue. See original summary.

jitendra verma’s picture

jitendra verma commented
Status: Active » Needs review
StatusFileSize
new integrate_token_module-2847556-2.patch1.74 KB

Token support added. kindly review

jitendra verma’s picture

jitendra verma commented
StatusFileSize
new integrate_token_module-2847556-3.patch1.68 KB

Token support added. kindly review

vaibhavjain’s picture

vaibhavjain
he/him
Primary language Hindi
Location Delhi
commented
Status: Needs review » Needs work 
  1. +++ b/src/Plugin/Field/FieldFormatter/RewriteFieldFormatter.php
@@ -127,6 +127,20 @@ class RewriteFieldFormatter extends FormatterBase implements ContainerFactoryPlu
+    if ( \Drupal::moduleHandler()->moduleExists('token') ) {

  2. +++ b/src/Plugin/Field/FieldFormatter/RewriteFieldFormatter.php
@@ -211,7 +225,10 @@ class RewriteFieldFormatter extends FormatterBase implements ContainerFactoryPlu
+        //Token Replacement.

    Space after // 

  3. +++ b/src/Plugin/Field/FieldFormatter/RewriteFieldFormatter.php
@@ -211,7 +225,10 @@ class RewriteFieldFormatter extends FormatterBase implements ContainerFactoryPlu
+        $node = $items->getEntity();
+        $token_service = \Drupal::token();
+        $output = $token_service->replace($custom_text, array('node'=>$node),  $options = array());

    We should be doing the token replacement for Prefix suffix as well. rather than just Custom text. Also, can you suggest if there is any other field we should cater this to ?

jitendra verma’s picture

jitendra verma commented
Status: Needs work » Needs review
StatusFileSize
new integrate_token_module-2847556-5.patch2.42 KB

Token replacement for Prefix suffix are added .
kindly review

vaibhavjain’s picture

vaibhavjain
he/him
Primary language Hindi
Location Delhi
commented
Status: Needs review » Needs work 
  1. +++ b/src/Plugin/Field/FieldFormatter/RewriteFieldFormatter.php
@@ -127,6 +127,20 @@ class RewriteFieldFormatter extends FormatterBase implements ContainerFactoryPlu
+    if ( \Drupal::moduleHandler()->moduleExists('token') ) {

    Coding standard issues here. The code should read - if (\Drupal::moduleHandler()->moduleExists('token')) 

  2. +++ b/src/Plugin/Field/FieldFormatter/RewriteFieldFormatter.php
@@ -208,10 +222,14 @@ class RewriteFieldFormatter extends FormatterBase implements ContainerFactoryPlu
+    ¶

    Extra spacing here. Should be removed 

  3. +++ b/src/Plugin/Field/FieldFormatter/RewriteFieldFormatter.php
@@ -208,10 +222,14 @@ class RewriteFieldFormatter extends FormatterBase implements ContainerFactoryPlu
+        // Token Replacement.        ¶

    Extra spacing here. Should be removed

jitendra verma’s picture

jitendra verma commented
Status: Needs work » Needs review
StatusFileSize
new integrate_token_module-2847556-7.patch2.42 KB

Coding standard issues Fixed.

jitendra verma’s picture

jitendra verma commented
StatusFileSize
new integrate_token_module-2847556-8.patch2.41 KB

Coding standard issues Fixed.
kindly review

vaibhavjain’s picture

vaibhavjain
he/him
Primary language Hindi
Location Delhi
commented
Status: Needs review » Needs work

ALl looks perfect. Can you also add the Token help for Prefix and suffix, as we are replacing tokens on these 2 fields as well.

jitendra verma’s picture

jitendra verma commented
StatusFileSize
new integrate_token_module-2847556-10.patch3.47 KB

Token help for Prefix and suffix are added .

jitendra verma’s picture

jitendra verma commented
StatusFileSize
new integrate_token_module-2847556-11.patch3.48 KB

Token help for Prefix and suffix are added .
kindly review

jitendra verma’s picture

jitendra verma commented
Status: Needs work » Needs review

Just changing status.

vaibhavjain’s picture

vaibhavjain
he/him
Primary language Hindi
Location Delhi
commented
Status: Needs review » Fixed

Fixed and committed. Thank you Jitendra.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.