When trying to add a Sub-conditional group operator to a webform conditional, i was receiving Undefined index: "andor".

I found that these errors were all reported on ternary operators, added additional validation that the array structure existed.

CommentFileSizeAuthor
#12 2847359-12-andor-conditional.patch861 bytesjoelpittet
#10 2847359-patch.diff2.09 KBnoisegatemedia
#9 2847359-patch.diff2.09 KBnoisegatemedia
#8 patch.diff2.09 KBnoisegatemedia
#5 Patch-2847359.diff2.09 KBnoisegatemedia
patch.diff2.09 KBnoisegatemedia
#2 2847038-patch.diff448 bytesnoisegatemedia

Comments

noisegatemedia created an issue. See original summary.

noisegatemedia’s picture

noisegatemedia commented
StatusFileSize
new 2847038-patch.diff448 bytes

Please ignore this patch, incorrect file uploaded.

noisegatemedia’s picture

noisegatemedia commented
noisegatemedia’s picture

noisegatemedia commented
noisegatemedia’s picture

noisegatemedia commented
StatusFileSize
new Patch-2847359.diff2.09 KB

The last submitted patch, 2: 2847038-patch.diff, failed testing.

Status: Needs review » Needs work

The last submitted patch, 5: Patch-2847359.diff, failed testing.

noisegatemedia’s picture

noisegatemedia commented
StatusFileSize
new patch.diff2.09 KB
noisegatemedia’s picture

noisegatemedia commented
StatusFileSize
new 2847359-patch.diff2.09 KB
noisegatemedia’s picture

noisegatemedia commented
StatusFileSize
new 2847359-patch.diff2.09 KB
liam morland’s picture

liam morland
Primary language English
Location Ontario, CA 🇨🇦
commented

Possibly related: #2842513: Undefined index: operator in _webform_conditional_expand().

joelpittet’s picture

joelpittet
he/him
Primary language English
Location Vancouver
commented
Issue summary: View changes
Status: Needs work » Needs review
StatusFileSize
new 2847359-12-andor-conditional.patch861 bytes

I'm using dev release and also running into these notices. The source_type issue has been resolved in another issue, so just the andor index missing.

Too test I just add a bunch of conditionals and looked at the logs:

Notice: Undefined index: andor in webform_conditional_element_add() (line 767 of webform/includes/webform.conditionals.inc).

Rerolling this patch.

liam morland’s picture

liam morland
Primary language English
Location Ontario, CA 🇨🇦
commented

What are the steps to reproduce the problem? I tried following the description but could not get the error to appear.

joelpittet’s picture

joelpittet
he/him
Primary language English
Location Vancouver
commented

@Liam Morland Not exactly sure how to describe the problem... I guess it needs sub conditions already to trigger the bug and I added a few more and it $conditional['andor'] wasn't there when it was looking for it.

andrtroe’s picture

andrtroe commented

Its a little bit hard to read.
Can we replace it with something like
$current_op = isset($conditional['andor']) && $parent_rid < 0
? $conditional['andor']
: $parent_values[$parent_rid]['operator'];

liam morland’s picture

liam morland
Primary language English
Location Ontario, CA 🇨🇦
commented

Maybe a better solution is to ensure andor is always set.

Figuring out the steps to reproduce the problem would likely make it easier to track down the best solution.

liam morland’s picture

liam morland
Primary language English
Location Ontario, CA 🇨🇦
commented
Status: Needs review » Closed (outdated)

Drupal 7 is no longer supported. If this applies to a supported version, please re-open.

Now that this issue is closed, please review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, please credit people who helped resolve this issue.