Problem/Motivation

Commit 71e0fba5e introduced a typo in the method addressed by the title (double hashmark)
$element['##attributes']['class'][] = 'field-group-html-element';

Proposed resolution

Fixing that typo

CommentFileSizeAuthor
#2 field_group-typo_in_plugin_htmlelement-2846589-2.patch801 byteshuzooka

Comments

huzooka created an issue. See original summary.

huzooka’s picture

huzooka
Primary language Hungarian
Location Hungary 🇭🇺🇪🇺
commented
Assigned: huzooka » Unassigned
Status: Needs work » Needs review
StatusFileSize
new field_group-typo_in_plugin_htmlelement-2846589-2.patch801 bytes
riddhi.addweb’s picture

riddhi.addweb commented
Status: Needs review » Reviewed & tested by the community

Hi huzooka,

Thanks! for the patch it works well.

  • zuuperman committed 24a5beb on 8.x-3.x authored by huzooka 
    Issue #2846589 by huzooka: Typo in Field Group Formatter Plugin...
nils.destoop’s picture

nils.destoop commented
Status: Reviewed & tested by the community » Fixed

Thx for noticing this. I committed it to dev.

  • zuuperman committed 2229046 on 8.x-1.x authored by huzooka 
    Issue #2846589 by huzooka: Typo in Field Group Formatter Plugin...
riddhi.addweb’s picture

riddhi.addweb commented

Hi Nils, I think you missed providing me RTBC credit. Can you please do the needful. Thanks!

  • zuuperman committed 65bedd6 on 8.x-3.x 
    Revert "Issue #2846589 by huzooka: Typo in Field Group Formatter Plugin...

  • zuuperman committed b18d005 on 8.x-3.x authored by huzooka 
    Issue #2846589 by huzooka, Jigar.addweb: Typo in Field Group Formatter...
nils.destoop’s picture

nils.destoop commented

Hi Jigar, I reverted the commit and re-committed with credits for everyone in this issue.

riddhi.addweb’s picture

riddhi.addweb commented

Thanks Nils, but thats strange..! Still I am unable to receive the credit.

nils.destoop’s picture

nils.destoop commented
Status: Fixed » Active
nils.destoop’s picture

nils.destoop commented
Status: Active » Fixed
nils.destoop’s picture

nils.destoop commented

Re-opening and placing back to fixed seems to give the credit :)

riddhi.addweb’s picture

riddhi.addweb commented

Thank you Nils, appreciate your efforts.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.