Tests are unable to run correctly. Patch coming.

CommentFileSizeAuthor
#10 content_access-automated-tests-fail-2846443-10.patch10.47 KBgisle
#9 content_access-fix_broken_tests-2846443.diff12.73 KBlpsolit
#6 content_access-fix_broken_tests-2846443.diff12.04 KBlpsolit
#3 content_access-fix_broken_tests-2846443.diff12.06 KBlpsolit
#2 content_access-fix_broken_tests-2846443.diff7.19 KBlpsolit

Comments

LpSolit created an issue. See original summary.

lpsolit’s picture

lpsolit commented
Status: Active » Needs review
StatusFileSize
new content_access-fix_broken_tests-2846443.diff7.19 KB

I renamed src/Tests/ContentAccessTestHelp.php to src/Tests/ContentAccessTestHelperTrait.php using "git mv", so I hope git won't complain that the patch doesn't apply due to the new file name.

lpsolit’s picture

lpsolit commented
StatusFileSize
new content_access-fix_broken_tests-2846443.diff12.06 KB

Looks like it didn't like the rename. 2nd attempt with a rm + add.

The last submitted patch, 2: content_access-fix_broken_tests-2846443.diff, failed testing.

The last submitted patch, 2: content_access-fix_broken_tests-2846443.diff, failed testing.

lpsolit’s picture

lpsolit commented
StatusFileSize
new content_access-fix_broken_tests-2846443.diff12.04 KB

The last submitted patch, 3: content_access-fix_broken_tests-2846443.diff, failed testing.

Status: Needs review » Needs work

The last submitted patch, 6: content_access-fix_broken_tests-2846443.diff, failed testing.

lpsolit’s picture

lpsolit commented
Status: Needs work » Needs review
StatusFileSize
new content_access-fix_broken_tests-2846443.diff12.73 KB

Missing test_dependencies on acl in .info.yml. I also added composer.json as someone said on IRC that it was necessary to make testbot happy.

gisle’s picture

gisle
he/him
Primary language Norwegian Bokmål
Location Norway
commented
StatusFileSize
new content_access-automated-tests-fail-2846443-10.patch10.47 KB

Patch don't apply. Rerolling for present HEAD.
Unsure about the TestBot and composer.json. First trying without.

gisle’s picture

gisle
he/him
Primary language Norwegian Bokmål
Location Norway
commented
Status: Needs review » Closed (outdated)

Ok, simpletests are deprcated: https://www.drupal.org/node/3091784

gisle’s picture

gisle
he/him
Primary language Norwegian Bokmål
Location Norway
commented
Assigned: lpsolit » Unassigned

gisle credited xeM8VfDh.

gisle’s picture

gisle
he/him
Primary language Norwegian Bokmål
Location Norway
commented
Status: Closed (outdated) » Fixed

Moving to "Fixed", to give credit to LpSolit.

The issue itself is outdated because the SimpleTest core module is deprecated: https://www.drupal.org/node/3091784 - but there is a lot of good work in the patch.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.