Replace usage of t() with $this->t() and use Drupal\Core\StringTranslation\StringTranslationTrait when necessary.

CommentFileSizeAuthor
#15 coding-standards-2846254-15.patch43.57 KBchakkche
#11 reroll-2846254.patch236.18 KBelber
#8 Captura de tela de 2022-04-06 15-56-52.png29.51 KBelber
#4 interdiff_exif_t_function_2846254_3_4.txt5.83 KBuseernamee
#4 exif_t_function_2846254_4.patch24.37 KBuseernamee
#3 exif_t_function_2846254_3.patch24.5 KBnkoporec
#2 exif_2846254_1.patch28.64 KBnehakhadke

Issue fork exif-2846254

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

nehakhadke created an issue. See original summary.

nehakhadke’s picture

nehakhadke commented
StatusFileSize
new exif_2846254_1.patch28.64 KB
nkoporec’s picture

nkoporec
Primary language English
Location Slovenia
commented
StatusFileSize
new exif_t_function_2846254_3.patch24.5 KB

This patch needs a reroll since tests have been deleted in the recent commit.Applying a new one.

useernamee’s picture

useernamee commented
StatusFileSize
new exif_t_function_2846254_4.patch24.37 KB
new interdiff_exif_t_function_2846254_3_4.txt5.83 KB

I have reviewed patch #3 and it had some errors ($this->t() calls inside static functions and there were few occurrences were $this was missing). I have removed this errors, here is the patch (and interdiff).

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Parent issue: » #3169084: Plan for EXIF 8.x-1.3
damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Issue summary: View changes
Status: Needs review » Needs work
Parent issue: #3169084: Plan for EXIF 8.x-1.3 »

This needs to be rerolled, and I think some of the changes won't work without adding a use statement for Drupal\Core\StringTranslation\StringTranslationTrait.

elber’s picture

elber
Primary language Portuguese, Brazil
Location Brazil
commented
Assigned: Unassigned » elber

Hi I will try to do a rerroll

elber’s picture

elber
Primary language Portuguese, Brazil
Location Brazil
commented
StatusFileSize
new Captura de tela de 2022-04-06 15-56-52.png29.51 KB

Hi I followed this doc (https://www.drupal.org/docs/develop/git/using-git-to-contribute-to-drupa...) but I couldn't to apply the patch #4. Can someone help me ?

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Version: 8.x-1.x-dev » 8.x-2.x-dev

A lot of the changes from the last patch no longer apply, so this needs to be reworked.

Also, please work from the 8.x-2.x branch, the 8.x-1.x branch is no longer supported.

elber’s picture

elber
Primary language Portuguese, Brazil
Location Brazil
commented

I will try it, thank you.

elber’s picture

elber
Primary language Portuguese, Brazil
Location Brazil
commented
Assigned: elber » Unassigned
Status: Needs work » Needs review
StatusFileSize
new reroll-2846254.patch236.18 KB
chakkche’s picture

chakkche commented
Assigned: Unassigned » chakkche

I will review this.

chakkche’s picture

chakkche commented
Status: Needs review » Needs work

I can still see lot of t() calls after applying the patch from #11 . i will work on this.

chakkche opened merge request !2

chakkche’s picture

chakkche commented
Assigned: chakkche » Unassigned
Status: Needs work » Needs review
StatusFileSize
new coding-standards-2846254-15.patch43.57 KB

Fixed t() calls & PHPCBF issues. Provided them in both merge request and patch file.

anabpv’s picture

anabpv
she/her
Location Portugal 🇵🇹
commented
Assigned: Unassigned » anabpv

I will review this

anabpv’s picture

anabpv
she/her
Location Portugal 🇵🇹
commented
Assigned: anabpv » Unassigned
Status: Needs review » Reviewed & tested by the community

Steps performed:
1 - downloaded the module and applied the commits from MR!2
2 - ran phpcs to properly review the t() calls
3 - checked the commits manually

Moving to RTBC.

  • DamienMcKenna committed bfe7b39 on 8.x-2.x 
    Issue #2846254 by chakkche, elber, useernamee, nehakhadke, nkoporec,...
damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Title: $this->t() should be used instead of t() for Drupal 8 version » $this->t() should be used instead of t()
Status: Reviewed & tested by the community » Fixed
Parent issue: » #3273802: Plan for Exif 8.x-2.4

Committed. Thanks everyone!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.