Closed (fixed)
Project:
Translation Management Tool
Version:
8.x-1.0
Component:
Core
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
24 Jan 2017 at 11:39 UTC
Updated:
7 Feb 2017 at 20:14 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
cburschkaComment #3
berdirDamn, that's a regression caused by #2834807: Make TranslatorPluginBase inherit Drupal's Core PluginBase. That's what you get when doing quick fixes before a release..
Comment #4
berdirReverted that, you should be able to switch to the latest dev in a few minutes.
Comment #5
cburschkaHmm... the error still occurs on the 8.x-1.x branch. I'm not sure how this change could've caused it, since it's on /admin/tmgmt/jobs, which directly goes to ContinuousJobForm which inherits TmgmtFormBase::create, and that's where the datetime.time service is requested. The plugins don't seem to be touched at that point...
Comment #6
cburschkaThe actual commit that broke it seems to be 691bbcc1 in #2840331: Missing parent call in TmgmtFormBase::__constuctor. Your parent::__construct call targets the 8.3.x version of ContentEntityForm:
The 8.2.5 version only takes the EMI:
Comment #7
cburschka(I can confirm that after reverting 691bbcc1, the /admin/tmgmt/jobs page works correctly.)
Comment #8
cburschkaThis removes the two extra arguments to bring the code in line with 8.2.5. :)
Comment #9
berdirI'm stupid. I reverted the right commit now :)
Comment #10
berdirThanks for testing.
Since i already reverted the other issue, this doesn't apply anymore. Feel free to provide a better patch for the other issue, closing this.
I also released 8.x-1.1 to fix this.