As per coding standard documentation at 'https://www.drupal.org/coding-standards/docs', @file tag docblock should not be there in the files that contain a namespaced class/interface/trait, whose file name is the class name with a .php extension.

CommentFileSizeAuthor
#2 queue_mail_2846234_1.patch4.75 KBnehakhadke

Comments

nehakhadke created an issue. See original summary.

nehakhadke’s picture

StatusFileSize
new4.75 KB

Status: Needs review » Needs work

The last submitted patch, 2: queue_mail_2846234_1.patch, failed testing.

steven jones’s picture

I'm not sure the change from t() to $this->t() is needed for test files? Or if it is, how you should include the t method correctly.

  • nehakhadke authored 7b4162e on 8.x-1.x
    Issue #2846234 by nehakhadke: Remove @file tag docblock from all the ....
  • sinn committed e97adbd on 8.x-1.x
    Issue #2846234 by nehakhadke: Remove @file tag docblock from all the ....

sinn credited sinn.

sinn’s picture

Status: Needs work » Fixed

it is OOP so let's use $this->t(). Added use StringTranslationTrait to include t() method correctly.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.