Theming guide link on appearance page in Drupal 8 points to www.drupal.org/theme-guide which redirects to www.drupal.org/docs/7/theming page. This is obviously the wrong page.

CommentFileSizeAuthor
#16 interdiff-theming_guide_link-2845371-12-15.txt327 byteschiranjeeb2410
#15 theming_guide_link-2845731-15.patch4.5 KBMunavijayalakshmi
#12 interdiff.txt1.83 KBAnonymous (not verified)
#12 theming_guide_link-2845731-12.patch4.5 KBAnonymous (not verified)
#10 7.docs_.links_.txt5.82 KBAnonymous (not verified)
#10 drupal.org_.links_.txt25.94 KBAnonymous (not verified)
#10 all.links_.txt65 KBAnonymous (not verified)
#7 theming_guide_link-2845731-7.patch3.86 KBashish-deynap
#6 theming_guide_link-2845731-6.patch1.26 KBchiranjeeb2410
#2 theming_guide_link-2845731-2.patch1.26 KBashish-deynap

Comments

tramsaal created an issue. See original summary.

ashish-deynap’s picture

ashish-deynap commented
StatusFileSize
new theming_guide_link-2845731-2.patch1.26 KB

Instances of incorrect link to Drupal 8 theming guide have been corrected.
Patch is attached.

ashish-deynap’s picture

ashish-deynap commented
Assigned: Unassigned » ashish-deynap
Status: Active » Needs review
chiranjeeb2410’s picture

chiranjeeb2410 commented
Status: Needs review » Reviewed & tested by the community

@ashish-deynap,

Patch applies well. Changing status to RTBC.

Anonymous’s picture

Anonymous (not verified) commented
Status: Reviewed & tested by the community » Needs review

Maybe better use https://www.drupal.org/docs/8/theming and try replace all links in core like:

- https://www.drupal.org/theme-guide
- https://www.drupal.org/theme-guide/8

+ https://www.drupal.org/docs/8/theming
chiranjeeb2410’s picture

chiranjeeb2410 commented
StatusFileSize
new theming_guide_link-2845731-6.patch1.26 KB

Made the required changes. Uploading patch.

ashish-deynap’s picture

ashish-deynap commented
StatusFileSize
new theming_guide_link-2845731-7.patch3.86 KB

Attached is the patch with removed all instances of incorrect links to theme guide.

Anonymous’s picture

Anonymous (not verified) commented

#7 looks nice! After this patch we have only two problems here:

- https://www.drupal.org/documentation/theme
+ https://www.drupal.org/docs/8/theming

And one problem here:

- https://www.drupal.org/theme-guide/8/classy
+ https://www.drupal.org/docs/8/theming-drupal-8/using-classy-as-a-base-theme

I'm not found other problems with links to the theme documentation. But maybe we need create same issues for modules and api guide links? Example:

- https://www.drupal.org/developing/modules/8
+ https://www.drupal.org/docs/8/creating-custom-modules

- https://www.drupal.org/documentation/modules/MODULE-NAME
+ https://www.drupal.org/docs/8/core/modules/MODULE-NAME/overview

- https://www.drupal.org/developing/api/8/render/arrays/cacheability/auto-placeholdering
+ https://www.drupal.org/docs/8/api/render-api/auto-placeholdering

But it is better to know what to do from some more experienced developer.

Anonymous’s picture

Anonymous (not verified) commented

Example, maybe we can upgrade all old links by script, that get the final forwarding address. I could try to do it in this week, if nobody has ready solution for this (or interest to do it), of course.

Anonymous’s picture

Anonymous (not verified) commented
StatusFileSize
new all.links_.txt65 KB
new drupal.org_.links_.txt25.94 KB
new 7.docs_.links_.txt5.82 KB

OK. I made an ugly and slow script. It detected a 3093 links in /core folder and checked their status. Next exluded /core/assets/vendor folder. If anyone is interested:

Any idea what to do next?

xjm’s picture

xjm
she/her
Primary language English
commented
Title: Theming guide link is wrong » Theming guide links are wrong
Version: 8.2.5 » 8.4.x-dev
Priority: Minor » Normal
Parent issue: » #2855175: [META] Many documentation / handbook URLs redirect to D7 content

Ah, #2854586: Stark's helptext link redirects to D7 theme guide was a partial duplicate of this.

I'd like to check all of core for redirected links, and then start from that big picture to fix things. Otherwise we'll be rolling small and duplicate patches for a long time. See #2855175: [META] Many documentation / handbook URLs redirect to D7 content; maybe we can start that discussion on that issue? @valpas your research would be good to repost there.

Thanks!

Anonymous’s picture

Anonymous (not verified) commented
StatusFileSize
new theming_guide_link-2845731-12.patch4.5 KB
new interdiff.txt1.83 KB

@xjm, thanks! Repost done.

Reroll #7 after #2854586: Stark's helptext link redirects to D7 theme guide + first half of #8 (see interdiff).

chiranjeeb2410’s picture

chiranjeeb2410 commented
Munavijayalakshmi’s picture

Munavijayalakshmi commented
Status: Needs review » Needs work 
+++ b/core/themes/classy/README.txt
@@ -8,10 +8,10 @@ To use Classy as your base theme, set the 'base theme' in your theme's .info.yml
+See https://www.drupal.org/docs/8/theming for more information on Drupal theming.

Line exceeding 80 characters.

Munavijayalakshmi’s picture

Munavijayalakshmi commented
Status: Needs work » Needs review
StatusFileSize
new theming_guide_link-2845731-15.patch4.5 KB

#14 Fixed. Applied the patch, Please review.

chiranjeeb2410’s picture

chiranjeeb2410 commented
Status: Needs review » Reviewed & tested by the community
StatusFileSize
new interdiff-theming_guide_link-2845371-12-15.txt327 bytes

Change is good. Patch applies cleanly. Uploading interdiff. Updating to RTBC.

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 15: theming_guide_link-2845731-15.patch, failed testing.

xjm’s picture

xjm
she/her
Primary language English
commented
Version: 8.4.x-dev » 8.3.x-dev
Status: Needs work » Fixed
Issue tags: +rc eligible

Okay, thanks! I went over these carefully and also over the results on #2855175: [META] Many documentation / handbook URLs redirect to D7 content.

There is one additional reference to this link in: core/modules/migrate_drupal/tests/fixtures/drupal7.php

But that is a Drupal 7 migration test fixture, specifically about the Drupal 7 theme, so we should not change that one.

At first I thought #14 did not exceed 80 characters, because Dreditor did not show it going over the 80-character line. But then I checked it in my editor and it turns out @Munavijayalakshmi is right; it is 81 characters. Good catch!

Since we have a working patch here and this covers all the cases we need to fix for this link, I think this is a good scope. Further patches to correct other links should be done as part of #2855175: [META] Many documentation / handbook URLs redirect to D7 content as we will coordinate them there.

As a documentation improvement, this change is also rc-eligible. Committed to 8.4.x and 8.3.x. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.