Closed (fixed)
Project:
Drupal core
Version:
8.4.x-dev
Component:
migration system
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Reporter:
Created:
20 Jan 2017 at 23:52 UTC
Updated:
5 Apr 2017 at 22:59 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
quietone commentedComment #3
phenaproximaSelf-assigning for review.
Comment #5
ultimikeI think an example of this would be useful. The explanation makes sense, but an example would be very helpful. I did a quick search in core and didn't find anywhere multiple source properties are used.
Hmm - well, when using the static map process plugin, using multiple source properties is a somewhat common thing...
Comment #6
jofitzAdded an example of multiple sources, as suggested by @ultimike.
Comment #7
phenaproximaI think we should expand on this a bit. Maybe an example? If this is just something defensive that the plugin does internally, maybe we should simply omit this passage.
Comment #8
heddnFor a non-English speaker, the docs could be clearer. What is it doing? It is getting a value from the Row. Let's describe it then put in an example.
Comment #9
quietone commentedOne small thing.
s/keys/keys:/
Comment #10
yogeshmpawarChanges done as per comment #9 & also added interdiff.
Comment #11
yogeshmpawarComment #12
phenaproximaKicking back to NW until #8 is addressed.
Comment #13
jofitzTried to improve the readability of the docs in response to #8. Also corrected an indentation error.
Comment #14
phenaproximaI think the properties have to be flush with the word "Available".
Other than that, this looks pretty good. RTBC from me once this nit is fixed.
Comment #15
jofitzThose indentations catch me out so often! Fixed now.
Comment #16
phenaproximaComment #17
alexpottCommitted and pushed 4ea838b to 8.4.x and 6e953b8 to 8.3.x. Thanks!