Add a normalizer for Menu Link Content items.

This is part of a 3-part change request, initiated by #2670954-26: Add Better Normalizers as a dependency

Comments

aaronbauman created an issue. See original summary.

aaronbauman’s picture

Status: Active » Needs review
StatusFileSize
new8.01 KB
sam152’s picture

Status: Needs review » Needs work

Just committing this without a test is a bit harder because it would require quite a lot of understanding and manual testing. I realise the file entity normalizer included now also doesn't have a test, so the precent is set pretty poorly, but I think the complexity of this patch more than warrants one.

aaronbauman’s picture

Status: Needs work » Needs review
StatusFileSize
new14.08 KB

OK, Entity Pilot has a test for this normalizer.
I've had to adjust the tests denormalize() slightly, but the principal is the same.

Please review, thanks!

sam152’s picture

Status: Needs review » Fixed

Need to commit this to enable automated testing. I haven't tested this but being in entity pilot and having a test are pretty good validation for this.

  • Sam152 committed df09fc0 on 8.x-1.x authored by aaronbauman
    Issue #2845455 by aaronbauman: Menu Link Content normalizer
    
aaronbauman’s picture

Great - thank you!

sam152’s picture

Is there a good 1 liner to describe what this does to add to the project page?

aaronbauman’s picture

Something like
"a menu link content normalizer which embeds dependencies on target entity, by UUID, when applicable"
or maybe
"entity-aware normarlizer for menu link content"

sam152’s picture

Added, thanks.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.