Add a normalizer for Menu Link Content items.
This is part of a 3-part change request, initiated by #2670954-26: Add Better Normalizers as a dependency
| Comment | File | Size | Author |
|---|---|---|---|
| #4 | better_normalizers-menu_link_content-2845455-2.patch | 14.08 KB | aaronbauman |
Comments
Comment #2
aaronbaumanComment #3
sam152 commentedJust committing this without a test is a bit harder because it would require quite a lot of understanding and manual testing. I realise the file entity normalizer included now also doesn't have a test, so the precent is set pretty poorly, but I think the complexity of this patch more than warrants one.
Comment #4
aaronbaumanOK, Entity Pilot has a test for this normalizer.
I've had to adjust the tests denormalize() slightly, but the principal is the same.
Please review, thanks!
Comment #5
sam152 commentedNeed to commit this to enable automated testing. I haven't tested this but being in entity pilot and having a test are pretty good validation for this.
Comment #7
aaronbaumanGreat - thank you!
Comment #8
sam152 commentedIs there a good 1 liner to describe what this does to add to the project page?
Comment #9
aaronbaumanSomething like
"a menu link content normalizer which embeds dependencies on target entity, by UUID, when applicable"
or maybe
"entity-aware normarlizer for menu link content"
Comment #10
sam152 commentedAdded, thanks.